Repository navigation
perf: drop per-row logging from column resolution - #88
Merged
Merged
Conversation
`ExecutionContext::resolve_column_index` logged every successful resolution. WHERE resolves each column operand of each row through it, and non-interactive mode records TRACE to a ring buffer and a log file, so the log cost more than the comparison it resolved for. The error paths keep their messages. Best of 3 over trades_100000.csv, ~2.4 s of which is the CSV load: WHERE price > quantity 3.34 s -> 2.42 s WHERE price > 100 2.83 s -> 2.42 s WHERE trader LIKE 'Trader0%' 2.87 s -> 2.43 s All three now run in load time. Follow-up to the same finding in R13 slice 4 (per-node logging in the value evaluator); it was the ~1 s that WHERE's own comparison path still carried afterwards. Parity report byte-identical, 826 lib + 498 integration tests pass. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the logging finding in R13 slice 4 (#87). That removed per-node logging inside the value evaluator; this removes the same thing one level down.
ExecutionContext::resolve_column_indexlogged every successful resolution. WHERE resolves each column operand of each row through it, and non-interactive mode records TRACE to a ring buffer and a log file, so the log cost more than the comparison it was resolving for — ~470 ms per column operand over 100k rows. Error paths keep their messages.Effect
Best of 3 over
trades_100000.csv, ~2.4 s of which is the CSV load:WHERE price > quantityWHERE price > 100WHERE trader LIKE 'Trader0%'All three now run in load time.
Verification
./run_all_tests.shgreen: 826 lib + 498 integration Rust tests, 572 Python, all FORMAL examples. The one SMOKE failure (expander_rewritersquery 7) also fails on main.Still outstanding, noted in the R13 entry: window evaluation logs
info!timings per row, which is outside R13's scope.🤖 Generated with Claude Code