Repository navigation
Adds new view_grants_analysis_view sql to tools - #351
Open
jwilson232 wants to merge 3 commits into
Open
jwilson232 wants to merge 3 commits into
jwilson232 wants to merge 3 commits into
Conversation
jwilson232
force-pushed
the
jw/view-latest-grant-fix
branch
from
October 7, 2026 13:32
ff2ce2e to
0e03231
Compare
jwilson232
force-pushed
the
jw/view-latest-grant-fix
branch
from
October 7, 2026 13:33
0e03231 to
bab5756
Compare
jwilson232
changed the title
drkane
approved these changes
Oct 29, 2026
| LEFT JOIN (SELECT | ||
| org_id, | ||
| name, | ||
| unnest(array_append(non_primary_org_ids, org_id)) AS all_ids |
Contributor
There was a problem hiding this comment.
My only worry with this is that we could end up with duplicate grants, in a case that two funders have the same org_id in the non_primary_org_ids field. Not sure if this would actually happen in practice but if it did then there would be duplicate grants.
I checked and this doesn't happen at the moment, so I don't think this should block the merge for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.