Repository navigation
fix(watch): a 4-frame sheet is 2x2, not 3x2 with two black cells - #8
Merged
Merged
Conversation
Measured on a live OoT run: four frames tiled 3x2 leave two black cells that look like frames the slicer lost. Columns now come from the frame count (ceil(sqrt(n)) capped at 3), so a blank cell only ever reads as padding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measured on a live OoT z-targeting run through the scaffolded-project path:
--frames 4tiled 3x2 and left two black cells, which read like frames the slicer failed to produce.Columns now come from the frame count (
ceil(sqrt(n)), capped at 3): 4 → 2x2, 2 → 2x1, 5 and 6 → 3x2, 12 → 3x4. At most one cell is ever blank.tests/watch.spec.mjspins the grid for 1, 2, 4, 5, 6 and 12 frames.npm test44/44.