Repository navigation
fix(watch): refuse a busy output folder before looking for tools - #7
Merged
Merged
Conversation
CI caught the order: a machine without yt-dlp reported the missing tool when the real complaint was a non-empty --out. Argument checks now run before tool discovery, so the first error a caller sees is the one they caused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI for #5 caught the order: on a runner without
yt-dlp, the watcher reportedyt-dlp not foundwhen the real complaint was a non-empty--out. Argument checks now run before tool discovery, so the first error a caller sees is the one they caused.Reproduced and verified with
PATH=/usr/bin:/bin(no yt-dlp anywhere): non-empty--outnow reportsoutput folder is not empty, exit 1.npm test44/44.npm testfailure only. Therelease:assetsstep also fails onmain, before any of my changes:carmageddonfetchesDethrace-labs/dethrace, which answers 403 ("Please ask the owner to check their account"). Main was green on 2026-10-28, so the upstream account was flagged since. That row has to move before any release can publish — an owner decision, not something to patch here.