Repository navigation
Merged
Conversation
…ing the page PRD-860's start gate made `rapier().setup` return its cleanup instead of `ready`, so nothing awaits the Wasm init any more: when a reload or a stop races it, the generation check threw into an unhandled rejection and the page reported it as a boot failure. That is what the 0.3.13 release proof hit once the retired `render` key stopped failing first — `TN_PLAYTEST_BRIDGE_MISSING ... rapier() was disposed before it initialized` — on both starter and platformer, in 24 s and 35 s. The superseded generation now installs nothing and resolves, reporting `TN_PHYSICS_SETUP_SUPERSEDED`; `recast()` skips installing into a context that is gone. A live game still fails closed (`TN_PHYSICS_NOT_READY`, and a `recast()` without a `rapier()` still throws). Verified: packages/physics 36 files / 280 tests (a new spec pins the dispose-races-init path: nothing installed, `runtime.rapier` untouched, the marker reported), `pnpm quality`, `pnpm typecheck`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second promotion for the 0.3.13 publish. The previous merge (
f5d255dfe) reached main green and re-cut the native tag, and the release lane then failed its own upgrade proof on a second blocker the first one had been hiding.What the proof reported (
pnpm:gameplay, starter and platformer, 24 s and 35 s):PRD-860's start gate made
rapier().setupreturn its cleanup rather thanready, so nothing awaits the Wasm init: when a reload or a stop races it, the generation check threw into an unhandled rejection and the page reported a boot failure it never had.The change: a superseded generation installs nothing and resolves, reporting
TN_PHYSICS_SETUP_SUPERSEDED;recast()skips installing into a context that is gone. A live game still fails closed (TN_PHYSICS_NOT_READY;recast()withoutrapier()still throws).Verified:
packages/physics36 files / 280 tests, including a new spec that drives setup → dispose → settle and asserts nothing was installed and the marker was reported;pnpm quality;pnpm typecheck;pnpm check:docs.Already on main from the previous promotion: the
render→rendereradoption, and worker errors that name their own line.