Repository navigation
CI: the native-engine job fetches basisu so the KTX2 tests can run - #658
Merged
Merged
Conversation
#635 (PRD-861, PRD-867) added native_engine_gltf_ktx2_* ctest cases that need third_party/basisu. The native-engine job, its Wasm-under-node step and the web engine action fetched only stb, cgltf, webp-source and meshopt, so the loader refused KTX2 by name and the three cases failed in 0.00 s (test-native red on every develop push since 39223c1). Local core-only build, CI's dependency list: 0 of 3 pass. With basisu: 3 of 3 pass.
jonit-dev
enabled auto-merge
November 10, 2026 22:37
Contributor
|
The merge queue stopped on
Fix, push, re-enqueue. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 10, 2026
jonit-dev
added a commit
that referenced
this pull request
Nov 11, 2026
… list #658 added basisu to the action's dependency loop, but the cache key hashed only the engine sources, so build-artifacts kept restoring the engine built without basisu (key native-engine-web-wasm-v2-...-ed22754e..., run 42932891905). test-native then failed "the web engine loads ktx2-textured.glb" with TN_..._UNSUPPORTED KHR_texture_basisu. The key now hashes the action file, whose dependency list decides what the engine links. Proof: ci-cache-keys spec red without the key change, green with it; all 28 scripts/__tests__/ci-* specs 891/891.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
The
native-engineCI job, its Wasm-under-node step and the web engine action now fetchbasisu(Basis Universal) together withstb cgltf webp-source meshopt.Why does it matter?
#635 (PRD-861, PRD-867) added three ctest cases,
native_engine_gltf_ktx2_*, that needthird_party/basisu. CI never fetched it, so the loader refused KTX2 by name and the cases failed in 0.00 s.test-nativehas been red on every develop push since39223c17a, andfail-fastthen cancelled the rest of the develop -> main run (#646).Done
basisu, 3 of 3 pass.Not run
native-enginejob, its Wasm step and the web engine build on CI. Those prove it.