Repository navigation
Conversation
…3.12 Release run 42307165770: the upgrade proof failed at TN_THREE_PATCH_PARTIAL, because #483 edited existing r187 hunks (hunk 4 of build/three.tsl.js and 10 other files) after 0.3.10 and 0.3.11 shipped them, and PRD-775 had dropped the prd269 upgrade patch. The upgrade patch maps the exact 0.3.11 blobs to the current ones; verified on stock three 0.187.0: 0.3.11 state -> current, stock -> current, second run unchanged. A spec now ties each upgrade target to the installed bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
It fixes the second blocker for the 0.3.12 publish. Games on 0.3.10 or 0.3.11 failed
pnpm installwhen they upgraded onto 0.3.12.Why does it matter?
Release run 42307165770 got past the release candidate, the tag and the native release. Its upgrade proof then failed at
TN_THREE_PATCH_PARTIAL, so nothing was published:build/three.tsl.js. 11 files changed.@threenative/core's postinstall recognized neither the stock text nor its own patched text.Every user who upgraded would have hit this error.
What changed
packages/core/patches/[email protected]maps the exact 0.3.11-patched blobs to the current patched blobs. 0.3.10 shipped the same patch as 0.3.11, so this file covers it too.three-patch-upgrade.spec.tshas a new test: every upgrade target must equal the installed patched bytes. A later patch edit without a regenerated upgrade file now fails in unit tests instead of in the release.packaging.spec.tsnow requires the packed tarball to ship the upgrade patch. It used to assert the opposite.Checks run
f23dc1e….b87cf38….unchanged.TN_THREE_PATCH_PARTIAL.unchanged.three-patch-upgrade.spec.tsandpackaging.spec.tspass (23 tests).pnpm typecheckpasses.