Repository navigation
feat(updater): localize in-app release notes - #461
Merged
Merged
Conversation
Keep the Chinese tag summary in the standard updater field and pass the English release summary in an additional manifest field. Select the summary using the active interface language so language changes also update a window that is already open. Require both summaries for future releases. Keep older manifests usable and omit the notes when the selected language is unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the Chinese release summary in the Chinese interface and the English summary in every other interface language.
The manifest keeps the standard Chinese
notesfield and addsnotes_enfrom the versioned English release summary. The update window selects the matching text when it renders, including after a language change. Older manifests still offer updates. A missing translation leaves the notes section hidden.Published releases now require both the Chinese tag annotation and the English summary at
release-notes/<version>.md. This is the follow-up to #460 for the same upcoming release.Covered by release manifest, updater, and frontend language selection tests.