Repository navigation
fix(web-tools): run tests with Enter in query inputs - #454
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing Enter in the web-tool tester previously did nothing because only the Run test button invoked the request. Search, Read page and Find in page inputs now run the same action on Enter.
Keyboard and button execution share the existing input and pending-request guards. IME confirmation, including WebKit's key code 229, and held-key repeats do not submit requests.
Validation: frontend typechecks and production Vite build passed. Real Chrome and WebKit keyboard checks verified all three actions, both Find in page inputs, button execution, blank input, IME confirmation, held-key repeats, pending-request protection and retry after failure.