Repository navigation
chore(release): prepare v0.8.3 - #12
Merged
Merged
Conversation
Enter on a bookmark seeked the player whatever played: a bookmark of book B moved book A. Stop the other playback and start the book or the episode of the bookmark at its time. ABS bookmarks have no episode ID. Find the episode of a podcast bookmark from the title prefix that handleAddBookmark writes. Show an error if no episode matches and the podcast does not play.
The unknown-episode test did not run the command that Enter returns, so its checks for no seek and no request could not fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request prepares v0.8.3. It has one commit of its own:
674ee34.The branch starts at the last commit of pull request #11, which is not in
mainat this time. So this pull request also shows the two commits of #11. Merge #11 first. As an alternative, merge only this pull request: it brings the commits of #11 tomain.v0.8.3 is the release of pull request #11 and of the commit
ce7ab8b, which changes two tests. No other change came after v0.8.2.Release preparation
docs/releases/v0.8.3.md: the release notes. They give the corrections in words for a user, and the changes of behavior that a user can see.README.mdanddocs/spruce/README.md: the new version in the release steps.Changes of behavior that the notes name:
—at its start.cannot find the episode of this bookmark.spruce has no change.
Verification
On Linux, on the commit of this pull request (
674ee34):gofmt -l .: no filego vet ./...: passgo build ./...: passgo mod verify: all modules verifiedgit diff --cached --checkbefore the commit: passgolangci-lint runwith version 2.14.0: 0 issuesPINE_REQUIRE_LIBMPV=1 PINE_REQUIRE_DBUS=1 go test ./... -count=1: 865 tests pass-race: 865 tests passscripts/release.sh: spruce links no pine-only package, and pine links no spruce package.Not verified
scripts/release.shdid not run. It makes the tag and publishes the GitHub Release.Releaseworkflow builds the binaries after the GitHub Release is published.ce7ab8bgives them a longer wait. CI ran two times on that commit, and the two runs passed. Two runs do not show that the fault is gone.After the merge, the release is one command on
main:🤖 Generated with Claude Code