refactor(refcountptr): Simplify RefCountPtr's Create_NoAddRef, Create_AddRef and add Assign_NoAddRef, Assign_AddRef - #3058
Open
xezon wants to merge 1 commit into
Open
Conversation
…_AddRef and add Assign_NoAddRef, Assign_AddRef
xezon
added
Minor
xezon
commented
Aug 5, 2026
| } | ||
|
|
||
| template <class T> | ||
| RefCountPtr<T> Create_NoAddRef(T *ptr) |
Author
There was a problem hiding this comment.
I wonder if we should name them
Create_Add_Ref
Create_No_Add_Ref
Assign_Add_Ref
Assign_No_Add_Ref
That would be more in line with the WWVegas naming convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change simplifies
RefCountPtr'sCreate_NoAddRef,Create_AddRefand addsAssign_NoAddRef,Assign_AddRef.Before
After
or
TODO