fix(particlesys): Load particle system templates in headless mode without retail compatibility - #3055
Open
Okladnoj wants to merge 1 commit into
Open
Conversation
Okladnoj
force-pushed
the
okji/fix/headless-particle-templates
branch
from
August 3, 2026 17:08
6b305c3 to
d656c3f
Compare
This was referenced Aug 3, 2026
githubawn
reviewed
Aug 3, 2026
xezon
reviewed
Aug 3, 2026
| // which are unfortunately needed to preserve the correct logic crc. | ||
| #else | ||
| virtual void init() override {} | ||
| virtual void reset() override {} |
There was a problem hiding this comment.
We did this intentionally. We do not want particles to be created, unless it compiles with retail compatible crc because of the particle logic coupling bugs.
We already fixed 3 other places where particles where coupled to logic.
You can find them by searching for // TheSuperHackers @fix The particle system is now decoupled from the logic crc
Please try to fix the particle logic coupling in SpectreGunshipUpdate instead of creating particle templates again.
Okladnoj
force-pushed
the
okji/fix/headless-particle-templates
branch
from
August 5, 2026 00:53
d656c3f to
23cbbf0
Compare
Author
Caball009
requested changes
Aug 5, 2026
Caball009
left a comment
Caball009
left a comment
There was a problem hiding this comment.
The title and description are no longer up-to-date, and provide inadequate rationale for this change. It's not at all clear to me why this change would be needed.
With RETAIL_COMPATIBLE_CRC=0 the headless dummy particle manager does not load particle system templates, so data->m_gattlingStrafeFXParticleSystem is null. The gattling targeting block was gated on that pointer, so a headless client skipped it and left m_gattlingTargetPosition and m_okToFireHowitzerCounter unchanged, diverging in logic crc from a graphical client; the howitzer GameLogicRandomValue calls then cascade the desync further. Run the targeting logic whenever the gattling is firing in the non-retail branch, independent of the template, and keep the template check only on the client-side particle creation. The original condition is preserved under RETAIL_COMPATIBLE_CRC so retail stays byte-identical even if an INI omits the particle template. Matches the pattern used in EMPUpdate, SpecialAbilityUpdate and TransitionDamageFX.
Okladnoj
force-pushed
the
okji/fix/headless-particle-templates
branch
from
August 5, 2026 10:21
23cbbf0 to
53458d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
RETAIL_COMPATIBLE_CRC=0the dummy manager overridesinitandresetwith no-ops, so particlesystem templates never load. Game logic reads those pointers:
SpectreGunshipUpdate.cpp:618skips itsgattling targeting block when the template is null and leaves
m_gattlingTargetPositionandm_okToFireHowitzerCounterunchanged. A headless client then diverges in logic CRC from a regular one.Now the templates load in both modes. The
createParticleSystemoverride from #3006 is kept in both modesas well, so particle systems still do not accumulate.
The base
createParticleSystemis now unconditionallyvirtual. It was already virtual in retail builds,so retail vtables and CRC are unchanged; without it the dummy override does not compile at
RETAIL_COMPATIBLE_CRC=0.Todo: