Forcing unknown parcelset settings by hkaiser · Pull Request #7828 · TheHPXProject/hpx

hkaiser · 2026-10-22T16:41:58Z

Fixes #7827

@OliverSchmitz: please check whether this fixes the issue you reported.

Signed-off-by: Hartmut Kaiser <[email protected]>

coderabbitai · 2026-10-22T16:43:28Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 70571839-e107-4e77-bb71-81bc3fcc8b62

Commits

Reviewing files that changed from the base of the PR and between 70ef42e and fa8acce.

Files selected for processing: 2

libs/full/parcelset/tests/regressions/CMakeLists.txt
libs/full/runtime_distributed/tests/unit/CMakeLists.txt

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

📝 Summary

Summary by CodeRabbit

Tests
- Updated zero-copy and parcel regression test configurations to use nonzero optimization and TCP message-size settings.
- The thread-mapper parcel-pool unit test is now included only when networking and TCP parcel support are enabled, and runs with four threads per locality.
- Other parcel-pool-related test coverage remains unchanged.

Parcelset test configurations now use updated INI arguments. The runtime-distributed unit-test configuration includes the parcel-pool test only when networking and the TCP parcelport are enabled.

Changes: Test configuration corrections

Layer / File(s)	Summary
Parcelset test arguments `libs/full/parcelset/tests/unit/CMakeLists.txt`, `libs/full/parcelset/tests/regressions/CMakeLists.txt`	The zero-copy unit tests and parcelset regression tests use `!=0` for the specified optimization and TCP message-size settings. The unit-test copyright year range now ends in 2026.
Parcel-pool test condition `libs/full/runtime_distributed/tests/unit/CMakeLists.txt`	`thread_mapper_parcel_pools` and its `THREADS_PER_LOCALITY 4` parameter are added only when networking and the TCP parcelport are enabled. `dijkstra_termination_forwarding` remains unconditional.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other · Severity of issue fixed: Medium

Merge Risk: Minimal · up to fa8ac

The test configuration changes are consistent with the intended Linux parcelport configurations and are ready to merge.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Out of Scope Changes check		The change of the copyright year from 2023 to 2026 in `libs/full/parcelset/tests/unit/CMakeLists.txt` has no demonstrated connection to issue `#7827` or to test configuration. The other parcelset test-a…	Remove the unrelated copyright year change from `libs/full/parcelset/tests/unit/CMakeLists.txt`.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly identifies the main change: forcing unknown parcelset settings to address the reported test failures.
Description check		The description references issue `#7827` and asks for verification of the fix. It is directly related to the test configuration changes.
Linked Issues check		The PR addresses both coding failures in issue `#7827`. `libs/full/parcelset/tests/regressions/CMakeLists.txt` changes the four MPI regression test invocations from `hpx.parcel.tcp.max_message_size=0` t…
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

Full details: Linked Issues check

Explanation

The PR addresses both coding failures in issue #7827. libs/full/parcelset/tests/regressions/CMakeLists.txt changes the four MPI regression test invocations from hpx.parcel.tcp.max_message_size=0 to the non-failing !=0 form. libs/full/runtime_distributed/tests/unit/CMakeLists.txt excludes thread_mapper_parcel_pools unless both networking and TCP are enabled. These CMake changes update automated test registration for the reported configuration.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Full details: Out of Scope Changes check

Explanation

The change of the copyright year from 2023 to 2026 in libs/full/parcelset/tests/unit/CMakeLists.txt has no demonstrated connection to issue #7827 or to test configuration. The other parcelset test-argument changes use the same unknown-setting handling as the reported regression tests and remain within the PR's stated testing scope.

Resolution

Remove the unrelated copyright year change from libs/full/parcelset/tests/unit/CMakeLists.txt.

Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codacy-production · 2026-10-22T16:43:37Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

OliverSchmitz · 2026-10-23T09:13:15Z

unfortunately I still get the same tests failing

The following tests FAILED:
        1201 - tests.regressions.modules.parcelset.distributed.mpi.nested_vectors_6623 (Failed)
        1202 - tests.regressions.modules.parcelset.distributed.mpi.very_big_parcel (Failed)
        1203 - tests.regressions.modules.parcelset.distributed.mpi.very_big_tchunk (Failed)
        1204 - tests.regressions.modules.parcelset.distributed.mpi.very_big_parcel_int_max_plus_1 (Failed)
        1261 - tests.unit.modules.runtime_distributed.thread_mapper_parcel_pools (Failed)
Errors while running CTest

hkaiser · 2026-10-23T10:12:01Z

unfortunately I still get the same tests failing

The following tests FAILED:
        1201 - tests.regressions.modules.parcelset.distributed.mpi.nested_vectors_6623 (Failed)
        1202 - tests.regressions.modules.parcelset.distributed.mpi.very_big_parcel (Failed)
        1203 - tests.regressions.modules.parcelset.distributed.mpi.very_big_tchunk (Failed)
        1204 - tests.regressions.modules.parcelset.distributed.mpi.very_big_parcel_int_max_plus_1 (Failed)
        1261 - tests.unit.modules.runtime_distributed.thread_mapper_parcel_pools (Failed)
Errors while running CTest

Can you give me the full error log, please?

OliverSchmitz · 2026-10-23T12:14:25Z

looks like the one before, sorry for not mentioning it

$ ctest --rerun-failed --output-on-failure
Test project /tmp/hpx_tests/build2
    Start 1201: tests.regressions.modules.parcelset.distributed.mpi.nested_vectors_6623
1/5 Test #1201: tests.regressions.modules.parcelset.distributed.mpi.nested_vectors_6623 ..............***Failed    0.38 sec
hpx::init: hpx::exception caught: Attempt to initialize unknown entry:  <command line definitions>: line 1 (offending entry: hpx.parcel.tcp.max_message_size=0): HPX(no_success)
hpx::init: hpx::exception caught: Attempt to initialize unknown entry:  <command line definitions>: line 1 (offending entry: hpx.parcel.tcp.max_message_size=0): HPX(no_success)
--------------------------------------------------------------------------
prterun detected that one or more processes exited with non-zero status,
thus causing the job to be terminated. The first process to do so was:

   Process name: [prterun-2502067@1,0]
   Exit code:    255
--------------------------------------------------------------------------
Process 0 failed with an unexpected error code of 255 (expected 0)
Base command is "/tmp/hpx_tests/build2/bin/nested_vectors_6623_test --hpx:ini=hpx.parcel.tcp.max_message_size=0 --hpx:ini=hpx.parcel.mpi.priority=1000 --hpx:ini=hpx.parcel.mpi.enable=1 --hpx:ini=hpx.parcel.bootstrap=mpi --hpx:threads=1 --hpx:localities=2"
Executing command: /opt/easybuild/foss2025a/software/OpenMPI/5.0.7-GCC-14.2.0/bin/mpiexec -n 2 /tmp/hpx_tests/build2/bin/nested_vectors_6623_test --hpx:ini=hpx.parcel.tcp.max_message_size=0 --hpx:ini=hpx.parcel.mpi.priority=1000 --hpx:ini=hpx.parcel.mpi.enable=1 --hpx:ini=hpx.parcel.bootstrap=mpi --hpx:threads=1 --hpx:localities=2

    Start 1202: tests.regressions.modules.parcelset.distributed.mpi.very_big_parcel
2/5 Test #1202: tests.regressions.modules.parcelset.distributed.mpi.very_big_parcel ..................***Failed    0.37 sec
hpx::init: hpx::exception caught: Attempt to initialize unknown entry:  <command line definitions>: line 1 (offending entry: hpx.parcel.tcp.max_message_size=0): HPX(no_success)
/tmp/hpx_tests/hpx/libs/full/parcelset/tests/regressions/very_big_parcel.cpp(161): test 'hpx::init(argc, argv, init_args) == 0' failed in function 'main': '-1' != '0'
0 sanity checks and 1 test failed.
--------------------------------------------------------------------------
prterun detected that one or more processes exited with non-zero status,
thus causing the job to be terminated. The first process to do so was:

   Process name: [prterun-2502073@1,1]
   Exit code:    1
--------------------------------------------------------------------------
Process 0 failed with an unexpected error code of 1 (expected 0)
Base command is "/tmp/hpx_tests/build2/bin/very_big_parcel_test --hpx:ini=hpx.parcel.tcp.max_message_size=0 --hpx:ini=hpx.parcel.mpi.priority=1000 --hpx:ini=hpx.parcel.mpi.enable=1 --hpx:ini=hpx.parcel.bootstrap=mpi --hpx:threads=1 --hpx:localities=2"
Executing command: /opt/easybuild/foss2025a/software/OpenMPI/5.0.7-GCC-14.2.0/bin/mpiexec -n 2 /tmp/hpx_tests/build2/bin/very_big_parcel_test --hpx:ini=hpx.parcel.tcp.max_message_size=0 --hpx:ini=hpx.parcel.mpi.priority=1000 --hpx:ini=hpx.parcel.mpi.enable=1 --hpx:ini=hpx.parcel.bootstrap=mpi --hpx:threads=1 --hpx:localities=2

    Start 1203: tests.regressions.modules.parcelset.distributed.mpi.very_big_tchunk
3/5 Test #1203: tests.regressions.modules.parcelset.distributed.mpi.very_big_tchunk ..................***Failed    0.37 sec
hpx::init: hpx::exception caught: Attempt to initialize unknown entry:  <command line definitions>: line 1 (offending entry: hpx.parcel.tcp.max_message_size=0): HPX(no_success)
--------------------------------------------------------------------------
prterun detected that one or more processes exited with non-zero status,
thus causing the job to be terminated. The first process to do so was:

   Process name: [prterun-2502079@1,1]
   Exit code:    255
--------------------------------------------------------------------------
Process 0 failed with an unexpected error code of 255 (expected 0)
Base command is "/tmp/hpx_tests/build2/bin/very_big_tchunk_test --hpx:ini=hpx.parcel.tcp.max_message_size=0 --hpx:ini=hpx.parcel.mpi.priority=1000 --hpx:ini=hpx.parcel.mpi.enable=1 --hpx:ini=hpx.parcel.bootstrap=mpi --hpx:threads=1 --hpx:localities=2"
Executing command: /opt/easybuild/foss2025a/software/OpenMPI/5.0.7-GCC-14.2.0/bin/mpiexec -n 2 /tmp/hpx_tests/build2/bin/very_big_tchunk_test --hpx:ini=hpx.parcel.tcp.max_message_size=0 --hpx:ini=hpx.parcel.mpi.priority=1000 --hpx:ini=hpx.parcel.mpi.enable=1 --hpx:ini=hpx.parcel.bootstrap=mpi --hpx:threads=1 --hpx:localities=2

    Start 1204: tests.regressions.modules.parcelset.distributed.mpi.very_big_parcel_int_max_plus_1
4/5 Test #1204: tests.regressions.modules.parcelset.distributed.mpi.very_big_parcel_int_max_plus_1 ...***Failed    0.37 sec
hpx::init: hpx::exception caught: Attempt to initialize unknown entry:  <command line definitions>: line 1 (offending entry: hpx.parcel.tcp.max_message_size=0): HPX(no_success)
/tmp/hpx_tests/hpx/libs/full/parcelset/tests/regressions/very_big_parcel.cpp(161): test 'hpx::init(argc, argv, init_args) == 0' failed in function 'main': '-1' != '0'
0 sanity checks and 1 test failed.
hpx::init: hpx::exception caught: Attempt to initialize unknown entry:  <command line definitions>: line 1 (offending entry: hpx.parcel.tcp.max_message_size=0): HPX(no_success)
/tmp/hpx_tests/hpx/libs/full/parcelset/tests/regressions/very_big_parcel.cpp(161): test 'hpx::init(argc, argv, init_args) == 0' failed in function 'main': '-1' != '0'
0 sanity checks and 1 test failed.
--------------------------------------------------------------------------
prterun detected that one or more processes exited with non-zero status,
thus causing the job to be terminated. The first process to do so was:

   Process name: [prterun-2502085@1,1]
   Exit code:    1
--------------------------------------------------------------------------
Process 0 failed with an unexpected error code of 1 (expected 0)
Base command is "/tmp/hpx_tests/build2/bin/very_big_parcel_test --hpx:ini=hpx.parcel.tcp.max_message_size=0 --nbytes-add=1 --hpx:ini=hpx.parcel.mpi.priority=1000 --hpx:ini=hpx.parcel.mpi.enable=1 --hpx:ini=hpx.parcel.bootstrap=mpi --hpx:threads=1 --hpx:localities=2"
Executing command: /opt/easybuild/foss2025a/software/OpenMPI/5.0.7-GCC-14.2.0/bin/mpiexec -n 2 /tmp/hpx_tests/build2/bin/very_big_parcel_test --hpx:ini=hpx.parcel.tcp.max_message_size=0 --nbytes-add=1 --hpx:ini=hpx.parcel.mpi.priority=1000 --hpx:ini=hpx.parcel.mpi.enable=1 --hpx:ini=hpx.parcel.bootstrap=mpi --hpx:threads=1 --hpx:localities=2

    Start 1261: tests.unit.modules.runtime_distributed.thread_mapper_parcel_pools
5/5 Test #1261: tests.unit.modules.runtime_distributed.thread_mapper_parcel_pools ....................***Failed    0.15 sec
Could not find usable bootstrap parcelport.
Preconfigured bootstrap parcelport: 'tcp'
List of available parcelports:
  mpi, priority: -100, can bootstrap: 1

terminate called without an active exception
Process 0 failed with an unexpected error code of -6 (expected 0)
Base command is "/tmp/hpx_tests/build2/bin/thread_mapper_parcel_pools_test --hpx:threads=4"
Executing command: /tmp/hpx_tests/build2/bin/thread_mapper_parcel_pools_test --hpx:threads=4


0% tests passed, 5 tests failed out of 5

Total Test time (real) =   1.69 sec

The following tests FAILED:
        1201 - tests.regressions.modules.parcelset.distributed.mpi.nested_vectors_6623 (Failed)
        1202 - tests.regressions.modules.parcelset.distributed.mpi.very_big_parcel (Failed)
        1203 - tests.regressions.modules.parcelset.distributed.mpi.very_big_tchunk (Failed)
        1204 - tests.regressions.modules.parcelset.distributed.mpi.very_big_parcel_int_max_plus_1 (Failed)
        1261 - tests.unit.modules.runtime_distributed.thread_mapper_parcel_pools (Failed)
Errors while running CTest

The parcelset regression tests set hpx.parcel.tcp.max_message_size, which is an unknown entry without the TCP parcelport; force it with '!='. thread_mapper_parcel_pools runs a single locality with networking enabled, which needs the TCP parcelport to bootstrap; build it only if TCP is enabled. Signed-off-by: Hartmut Kaiser <[email protected]>

hkaiser · 2026-10-25T15:41:21Z

@OliverSchmitz: the first commit fixed the wrong tests. The second commit forces the hpx.parcel.tcp.max_message_size setting in the parcelset regression tests and builds thread_mapper_parcel_pools only with the TCP parcelport, which it needs to bootstrap a single locality. Could you please check again?

StellarBot · 2026-10-25T16:07:22Z

Commit fa8acce640c37c6a8df9df77dee8adda4bbd3f98, Jenkins build 6174

Performance test report

Property	Reference	Current
Run date	2026-10-23T13:42:56.842260-05:00	2026-10-25T10:53:23.675956-05:00
Host	medusa12.rostam.cct.lsu.edu	medusa12.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/18.1.8/bin/clang++	/opt/apps/llvm/18.1.8/bin/clang++

Test name	Executor	Percentage Diff.	Classification
stream_report
stream benchmark - Copy	parallel_executor_default_parallel_policy_allocator	2.35 %	++
Plot

Explanation of Symbols

The benchmarks ran on medusa12, the results are compared with the references of that node.

Percentage Diff. is the change of the median time relative to the reference, positive values mean faster.

Symbol	Meaning
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval within ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected
no reference	No reference results for this node yet, the plot shows only the current results

OliverSchmitz · 2026-10-25T20:05:00Z

thanks, looks good!

100% tests passed, 0 tests failed out of 1493

Forcing unknown parcelset settings

70ef42e

Signed-off-by: Hartmut Kaiser <[email protected]>

hkaiser added this to the 2.0.0 milestone Oct 22, 2026

hkaiser added category: CMake type: enhancement category: parcel transport category: tests type: compatibility issue labels Oct 22, 2026

hkaiser merged commit 6b30e62 into master Oct 25, 2026
84 of 86 checks passed

hkaiser deleted the fixing_7827 branch October 25, 2026 22:45

hkaiser mentioned this pull request Oct 25, 2026

Preparing V2.0.0 #7547

Open

1 of 2 tasks

Navigation Menu

Repository navigation

Forcing unknown parcelset settings - #7828

Forcing unknown parcelset settings#7828
hkaiser merged 2 commits into
masterfrom
fixing_7827

hkaiser commented Oct 22, 2026

Uh oh!

coderabbitai Bot commented Oct 22, 2026 •

edited

Loading

Summary by CodeRabbit

Uh oh!

codacy-production Bot commented Oct 22, 2026

Uh oh!

OliverSchmitz commented Oct 23, 2026

Uh oh!

hkaiser commented Oct 23, 2026

Uh oh!

OliverSchmitz commented Oct 23, 2026

Uh oh!

hkaiser commented Oct 25, 2026

Uh oh!

StellarBot commented Oct 25, 2026

Explanation of Symbols

Uh oh!

OliverSchmitz commented Oct 25, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hkaiser commented Oct 22, 2026

Uh oh!

coderabbitai Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

codacy-production Bot commented Oct 22, 2026

Up to standards ✅

Uh oh!

OliverSchmitz commented Oct 23, 2026

Uh oh!

hkaiser commented Oct 23, 2026

Uh oh!

OliverSchmitz commented Oct 23, 2026

Uh oh!

hkaiser commented Oct 25, 2026

Uh oh!

StellarBot commented Oct 25, 2026

Explanation of Symbols

Uh oh!

OliverSchmitz commented Oct 25, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Oct 22, 2026 •

edited

Loading