[the-ivii]

Follow-up to #7757.

Proposed Changes

• Remove an externally injected --hpx:queuing option before the regression cases supply their own scheduler.
• Handle both --hpx:queuing=value and --hpx:queuing value forms.
• Preserve all other test-runner arguments, including the configured thread count.

Any background context you want to provide?

After #7757 merged, the queuing_options_7743 regression failed in configurations that set HPX_WITH_TESTS_COMMAND_LINE=--hpx:queuing=local-workrequesting-fifo. The test supplies a different scheduler for each runtime initialization, so program-options rejected the two occurrences before the assertions ran.

Validated with the failing CI configuration, including work-requesting schedulers and the globally injected scheduler option.

Checklist

Not all points below apply to all pull requests.

• I have added a new feature and have added tests to go along with it.
• I have fixed a bug and have added a regression test.
• I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3040dc11-a5f0-476b-a9f7-2892a093cd73

📥 Commits

Reviewing files that changed from the base of the PR and between cba138f and 6839380.

📒 Files selected for processing: 1

• libs/core/command_line_handling_local/tests/regressions/queuing_options_7743.cpp

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Summary

Summary by CodeRabbit

• Tests
  • Improved regression test reliability by filtering externally supplied queuing options before testing scheduler configurations.

The regression test filters --hpx:queuing options and their values from the incoming argument vector before running the existing scheduler test cases.

Changes: Queuing Option Regression Test

Layer / File(s)	Summary
Filter test arguments libs/core/command_line_handling_local/tests/regressions/queuing_options_7743.cpp	Adds remove_queuing_option to retain the program name and unrelated arguments while removing --hpx:queuing and its value, or --hpx:queuing=.... The test uses the filtered arguments for its scheduler cases.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 68393

The test filters the injected scheduler option while preserving the remaining arguments. No actionable merge-blocking risk is identified.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: fixing the queuing regression under configured schedulers.
Description check		The description directly explains the regression, the argument filtering changes, the supported option forms, and the validation performed.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

🧪 Generate unit tests (beta)

• Create a new PR

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[StellarBot]

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	FORK_JOIN_EXECUTOR_NOSTACK	PARALLEL_EXECUTOR	PARALLEL_SCHEDULER	SCHEDULER_EXECUTOR
For Each	(=)	(=)	(=)	(=)	(=)

Info

Property	Before	After
HPX Commit	36d11de	d0c7da2
HPX Datetime	2026-10-14T17:56:09+00:00	2026-10-18T13:46:32+00:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Clustername	rostam	rostam
Datetime	2026-10-14T13:06:52.713280-05:00	2026-10-18T08:56:47.691301-05:00
Compiler	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	=

Info

Property	Before	After
HPX Commit	36d11de	d0c7da2
HPX Datetime	2026-10-14T17:56:09+00:00	2026-10-18T13:46:32+00:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Clustername	rostam	rostam
Datetime	2026-10-14T13:08:45.592191-05:00	2026-10-18T08:58:39.547330-05:00
Compiler	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	--	-
Stream Benchmark - Scale	(=)	(=)	(=)
Stream Benchmark - Triad	(=)	-	(=)
Stream Benchmark - Copy	(=)	+	+

Info

Property	Before	After
HPX Commit	36d11de	d0c7da2
HPX Datetime	2026-10-14T17:56:09+00:00	2026-10-18T13:46:32+00:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Clustername	rostam	rostam
Datetime	2026-10-14T13:09:05.868380-05:00	2026-10-18T08:58:59.667420-05:00
Compiler	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

[hkaiser]

LGTM, thanks!

[hkaiser]

@the-ivii FWIW, the failing min_tasks_to_steal_staged will be fixed by #7771.