Chocolatey: tag-pinned PNG icon, distinct source URL, manual republish job - #111
Merged
Conversation
…publish job Moderator feedback on rackstack 1.123.1: raw.githubusercontent.com icons are not accepted. The nuspec now points at the release's own tag on jsDelivr and uses the PNG icon (the guideline prefers png/svg over ico). projectSourceUrl now differs from projectUrl and docsUrl points at the wiki, clearing the two guideline notes from the same review. RackStack.psd1 IconUri moved to the same CDN for consistency. ci.yml gains a workflow_dispatch job that rebuilds and re-pushes the Chocolatey package for an EXISTING release from its published hash, so a nuspec fix can land on a version already in moderation without rebuilding the EXE or cutting a new version. The normal job is skipped on dispatch. Pack verified locally against the stamped 1.123.1 nuspec; 5514/5514 tests.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answers the moderator review on rackstack 1.123.1 (raw.githubusercontent.com icon not accepted) and the two guideline notes from the same review.
iconUrl->https://cdn.jsdelivr.net/gh/TheAbider/RackStack@v{ver}/.github/assets/icon.png(tag-pinned CDN, PNG per the png/svg guideline). Stamped with the release version in both publish paths.projectSourceUrlnow differs fromprojectUrl;docsUrlpoints at the wiki.RackStack.psd1IconUri on the same CDN for consistency.workflow_dispatchjobrepublish-chocolatey(input: version) rebuilds the .nupkg from the current templates and the published release's own hash, then re-pushes. The EXE is not rebuilt, so the hash, cosign signature, and antivirus submission for 1.123.1 stay valid. The normaltestjob is skipped on dispatch.