Quote the compiler arguments in the release compile step (v1.123.1) - #109
Merged
Conversation
Under pwsh 7, which runs the release job, /resource:$embedded reached csc.exe with the variable unexpanded and the v1.123.0 build failed before producing an executable. All csc arguments are now passed as quoted strings, which both PowerShell editions expand identically. Verified by running the exact step under pwsh 7.6.5 and Windows PowerShell 5.1.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.123.0 release job failed at "Compile RackStack.exe": under pwsh 7 the
/resource:$embedded,RackStack.ps1argument reached csc.exe with the variable unexpanded (error CS1566: Error reading resource file '...\'). All compiler arguments are now quoted strings, which both PowerShell editions expand identically.Verified by running the exact step under pwsh 7.6.5 and Windows PowerShell 5.1 locally; both produce an EXE with the correct version resource and the embedded resource byte-identical to the monolithic. 5511/5511 structural tests.
Version bumped to 1.123.1 because release detection compares Header.ps1 against the previous commit.