Repository navigation
Improve uploads and add external editor support - #9
Merged
Merged
Conversation
Pipeline SFTP writes with bounded concurrency to avoid waiting for a round trip after every chunk, and upload up to four files concurrently with one progress dialog showing file and byte counts, themed progress, live transfer speed, and cancellation. Add an Open Externally context-menu action for text files, with guarded UTF-8 decoding, large-file confirmation, and serialized saves. Prevent Enter and Escape in rename and create inputs from triggering the grid's global keyboard shortcuts. Route single- and multi-file drops through the shared upload dialog.
|
AI review | Needs changes Adds pipelined SFTP uploads, multi-file progress tracking, and an external editor workflow. The BOM handling contradicts the PR description, and the PR title misses the required conventional prefix.
Reviewed 8f84e07. AI can be wrong, a maintainer still decides. Comment |
Replace the upload speed fallback with an invisible non-breaking space and reserve right-aligned space for the reading. Decode base64 in 3 MB slices into a preallocated byte array when opening files externally. Add round-trip tests for empty, small, and multi-slice inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline SFTP writes with bounded concurrency to avoid waiting for a round trip after every chunk, and upload up to four files concurrently with one progress dialog showing file and byte counts, themed progress, live transfer speed, and cancellation.
Add an Open Externally context-menu action for text files, with guarded UTF-8 decoding, large-file confirmation, and serialized saves. Prevent Enter and Escape in rename and create inputs from triggering the grid's global keyboard shortcuts. Route single- and multi-file drops through the shared upload dialog.
Overview
Improve SFTP upload throughput and provide a shared, cancellable upload experience. Add a safer external-editor workflow for text files and prevent rename/create keyboard shortcuts from leaking into the grid.
Changes Made
fileManager.openExternalEditorlabel; added the English keysexternalEditorTextOnlyanduploadFilesDone.Related Issues
Screenshots / Demos
Checklist
CHANGELOG.md(if the repo has one) —CHANGELOG.mdis unchanged and has no Unreleased section.CONTRIBUTING.md— it lists build, test, typecheck, manifest validation, and Prettier commands.Only the desktop app was manually tested (Open Externally, upload dialog, rename on Enter, and upload speed); other locales were not updated. No real-SFTP benchmark numbers are available. Partial remote files after failed uploads are a pre-existing behaviour.