Repository navigation
Conversation
- Re-measure the grid after a tab becomes visible and keep list rows at a fixed height - Memoize selected and dragged paths, and pass sudo passwords over stdin - Extract file filtering and sorting with a shared collator and add tests
|
AI review | Looks safe to merge Fixes virtualizer layout glitches in hidden tabs, optimizes list rendering with memoized sets, and secures sudo password handling by piping it via stdin. No rule violations or security risks found. Reviewed e0cbccd. AI can be wrong, a maintainer still decides. Comment |
Author
|
Finding 1 is fixed: the test helper now returns a typed |
Member
|
Thanks! This is included in #20, which carried these commits and is now merged into dev-1.1.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-measure the grid after a tab becomes visible and keep list rows at a fixed height
Memoize selected and dragged paths, and pass sudo passwords over stdin
Extract file filtering and sorting with a shared collator and add tests
Overview
Fixes two grid layout glitches in the file manager and stops sudo passwords from showing up in the process list.
Changes Made
list-routes.ts): the password is now written to sudo's stdin (sudo -S -p '') instead ofecho 'pw' | sudo, so it no longer appears in the process list.filterAndSortFiles(src/frontend/file-list.ts), which uses one sharedIntl.Collatorand a lowercased query computed once. It has two new tests.Related Issues
Screenshots / Demos
None attached.
Checklist
npm testpassed earlier (49 files, 274 tests), before the final prettier pass. No typecheck was run.CHANGELOG.mdCONTRIBUTING.md