Repository navigation
fix: clear the directory validator's credential holds - #9
Merged
Merged
Conversation
The validator read "$290M" in the trade skill as a shell variable and the json-schema.org "$schema" URLs in the eval tool mock as a remote host next to credential-named fields. Write the amount as USD and strip "$schema" from the mock, including in its refresh command. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Claude Directory validator held the plugin for two false positives. Neither file reads a credential.
skills/trade-intelligence/SKILL.md: the example "$290M est." was read as a shell variable. It's now "USD 290M est."evals/mocks/terminal49/_tools.json: the"$schema": "https://json-schema.org/..."keys put a remote URL beside thewhoamischema's credential-named fields (api_key,shared_token). The mock no longer has$schemakeys, and the refresh command inevals/README.mdstrips them too. All 30 tools and their schemas are otherwise unchanged.npm run validatepasses.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.