Repository navigation
fix: match the existing OpenAI app's MCP URL in the ZIP - #13
Conversation
OpenAI rejected the upload because the ZIP's MCP URL must match the existing app's exactly, and the app was registered as https://mcp.terminal49.com/ with a trailing slash. Set mcpUrl in openai/listing.json and apply it only to the OpenAI ZIP. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f08795e50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!/^[a-z0-9]+(-[a-z0-9]+)*$/.test(listing.name ?? "") || listing.name.length > 64) { | ||
| errors.push("openai/listing.json name must be the OpenAI package name"); | ||
| } | ||
| if (listing.mcpUrl !== undefined && !/^https:\/\/mcp\.terminal49\.com(\/[a-z]*)?$/.test(listing.mcpUrl)) { |
There was a problem hiding this comment.
When mcpUrl is changed to a lowercase path such as https://mcp.terminal49.com/mcp, this regex accepts it and the builder copies it directly into the ZIP, even though such paths are prohibited and would no longer exactly match the existing app URL. Validate against the one registered URL (including its required trailing slash) rather than permitting arbitrary suffixes.
AGENTS.md reference: AGENTS.md:L10-L12
Useful? React with 👍 / 👎.
OpenAI rejected the 1.1.0 upload: "The MCP URL must match the existing app. Restore its original URL and reupload." The existing app is registered as
https://mcp.terminal49.com/, with a trailing slash. Our.mcp.jsonhas no slash.openai/listing.jsonsetsmcpUrl, and the ZIP builder uses it for the OpenAI ZIP only. The shared.mcp.jsonused by Claude, Codex, and Cursor doesn't change.npm run validateandnpm run build:openai-zippass.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.