Repository navigation
fix(cooperation): recover frame coverage during synchronization - #549
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pages with failed child iframes could never complete
cooperate syncbecause a missing content-script receiver aborted collection for the entire tab. Skip failed child frames and inactive documents, report them inframe_gaps, and repair missing collectors immediately using the existing capture script. Active frames still require coverage; a failed main page remains an error.Frame diagnostics retain only HTTP(S) origins and paths; other URLs show only their scheme. Malformed URLs use a placeholder without interrupting collection. Repair attempts are shared per current document and removed when the document leaves the tab. The existing WXT entrypoint disposes previous collectors when reinjected; the browser regression now tests that shipped entrypoint, including delayed declared-script startup and extension reload.
Return
frame_unobservableandpage_load_failedfor diagnosed collection failures. When a bounded wait reports temporary unavailability,--settlecontinues its remaining sync attempts and returns the last real sync error if all three fail. It neither invents a permanent frame failure nor recommends reloading for a temporary wait timeout. Human control retainsnot_ready, including explicit holds during navigation, and status/wait reportscontrol_policy: nulluntil policy negotiation succeeds.Validation:
Fixes #545.