Skip to content

bump node version to 26.10.0 #8509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schiller-manuel merged 4 commits into from
Oct 17, 2026
Merged

bump node version to 26.10.0 #8509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
56cac83
bump node version to 26.10.0
schiller-manuel Sep 26, 2026
1bc07c2
run benchmarks on .nvmrc changes
schiller-manuel Sep 26, 2026
7be601e
Rename client-nav-benchmarks.yml to benchmarks.yml
schiller-manuel Sep 26, 2026
9148d37
chore(ci): update references to the renamed benchmarks workflow
schiller-manuel Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/client-nav-benchmarks.yml → .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@ on:
- '!packages/**/__tests__/**'
- '!packages/**/*.test.*'
- 'benchmarks/**'
- '.nvmrc'
workflow_dispatch:

concurrency:
group: client-nav-benchmarks-${{ github.ref }}
group: benchmarks-${{ github.ref }}
cancel-in-progress: false
queue: single

Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
24.8.0
26.10.0

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin an actually published Node version

At this commit's September 26 timestamp, Node 26.10.0 has not been released, so nvm install or nvm use on a clean checkout cannot resolve the version and contributors cannot run the repository's mandated installation and validation flow. Pin the latest published Node 26 release or retain 24.8.0 instead.

AGENTS.md reference: AGENTS.md:L13-L13

Useful? React with 👍 / 👎.

@schiller-manuel schiller-manuel Sep 26, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really? what about https://nodejs.org/en/download/current

2 changes: 1 addition & 1 deletion benchmarks/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ Node and use `setImmediate` directly.
Dispatch the existing `Benchmarks` workflow against an unchanged branch:

```sh
gh workflow run client-nav-benchmarks.yml --ref <branch>
gh workflow run benchmarks.yml --ref <branch>
```

Wait for each workflow run to finish before dispatching the next repetition at
Expand Down
4 changes: 2 additions & 2 deletions benchmarks/memory/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Dedicated memory benchmarks for TanStack Router / Start, measured with the
CodSpeed **memory instrument** (`mode: memory` in
`.github/workflows/client-nav-benchmarks.yml`). The workflow runs on every
`.github/workflows/benchmarks.yml`). The workflow runs on every
push to `main` except docs/examples/e2e-only pushes: CodSpeed compares a PR
against the run on its merge-base commit, and a main commit without a run makes
CodSpeed silently fall back to an older base — a single outlier base run then
Expand Down Expand Up @@ -258,7 +258,7 @@ WITH_INSTRUMENTATION=1 codspeed run --mode memory -- pnpm nx run @benchmarks/mem
Run the benchmark workflow on an experiment branch:

```bash
gh workflow run client-nav-benchmarks.yml --ref <experiment-branch>
gh workflow run benchmarks.yml --ref <experiment-branch>
```

Repeat at the same commit, using distinct branch names if runs should overlap
Expand Down
Loading