You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix nightly demand coverage campaign setup and time budget - #2361
The nightly persisted-demand coverage job failed before completing its intended checks: missing built package exports caused 19 source type errors, and tenfold campaigns retained the ordinary three-minute timeout. After those blockers, P22 also refused to run because its target matched two abort handlers.
Build the SQLite-core dependency graph through the same entry point as PR CI, scale campaign timeouts with the existing run multiplier, and target P22 specifically at the covered-demand wait. Default timeouts, history counts, required reach, comparisons, and the exactly-one-match guard remain unchanged. No production JavaScript changes.
🔬 Oracle Coverage
Existing owner: persisted demand coverage, including packages/db-sqlite-persistence-core/tests/persisted-demand-coverage-campaign-oracle.test.ts. This change repairs campaign execution and mutant targeting; it preserves the existing model, history grammar, comparisons and reach requirements. P22 removes the covered-wait abort listener while retaining upstream promise settlement; an exact-target probe confirms it matches once and changes the source.
Validation at eb83d26e3:
Reproduced all 19 missing-build type errors; the dependency build and subsequent TypeScript check pass.
Reproduced the unchanged tenfold fixed campaign timing out at 180 seconds.
Both repaired tenfold campaigns pass: fixed seed 2102 and captured nightly seed -1145433908, 580 histories each, 1,160 total. All 15 reach requirements pass in both campaigns; the least frequent reached state occurs in 51 and 50 histories, respectively. Suite: 10 tests passed, no type errors, 1,790 seconds total.
Ordinary fixed/fresh campaigns and direct required-history replay pass.
All 42 mutant outcomes match expectations: 30 rejected by named tests, 12 documented equivalent mutants survived. P22 fails the release-wait test. No missing targets, timeouts, or setup errors.
Formatting, changed-file lint, and whitespace checks pass. All PR checks pass; CodeRabbit subsequently reviewed this head with no actionable comments. Its summary incorrectly described P22 as a no-op; the exact-target probe and completed mutant sweep establish the listener removal.
The earlier release test and benchmark runs were fixed by merged #2359. This PR addresses nightly run 42232862302. It repairs execution setup and time allowance without changing the persisted-demand law, model, histories, driver, or oracle judgment. The evidence covers the existing controlled-core histories and observations; it adds no provider, framework, or multi-tab coverage claim. The historical red runs remain red; replacement checks validate this head.
✅ Checklist
Tested the affected campaign locally, including both tenfold runs, replay and the complete mutant sweep. Full PR tests pass in CI.
🚀 Release Impact
This change is docs/CI/dev-only (no release). No package source changes or changeset required.
Summary by CodeRabbit
Tests
Updated campaign test timing to use a shared timeout that adapts to the configured oracle run duration.
Nightly verification now builds the SQLite core dependencies before running campaign and demand-coverage checks.
Corrected a demand-coverage mutation case; it no longer changes the promise-settlement expression.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
No actionable comments were generated in the recent review.
Walkthrough
The nightly workflow now builds sqlite-core before running oracle checks. The campaign tests share a timeout computed with oracleRuns(180_000). Mutant P22 no longer targets the abort-event listener.
The workflow builds sqlite-core before the nightly checks. Both campaign tests use the shared campaignTimeoutMs. P22 now targets only the upstream-promise settlement expression and replaces it with the same expression.
TanStack/db#2237 — Changes replay-selection helpers used by the demand coverage campaign.
TanStack/db#2236 — Changes replay options used by campaign tests whose timeout this PR updates.
Merge Risk: Minimal · up to eb83d
Nightly checks build their dependencies and scale campaign timeouts. No merge-blocking issue was identified.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title identifies the nightly campaign setup and timeout changes.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description covers the required sections and reports targeted tests and CI results. It does not confirm a local pnpm test run. The P22 file summary conflicts with the description; the diff is ne…
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)
Full details: Description check
Explanation
The description covers the required sections and reports targeted tests and CI results. It does not confirm a local pnpm test run. The P22 file summary conflicts with the description; the diff is needed to verify the mutant behavior.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Tip
🎯 Customize your risk assessments
Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.
✅ Automatic approvals, with your rules
Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
The nightly persisted-demand coverage job failed before completing its intended checks: missing built package exports caused 19 source type errors, and tenfold campaigns retained the ordinary three-minute timeout. After those blockers, P22 also refused to run because its target matched two abort handlers.
Build the SQLite-core dependency graph through the same entry point as PR CI, scale campaign timeouts with the existing run multiplier, and target P22 specifically at the covered-demand wait. Default timeouts, history counts, required reach, comparisons, and the exactly-one-match guard remain unchanged. No production JavaScript changes.
🔬 Oracle Coverage
Existing owner: persisted demand coverage, including
packages/db-sqlite-persistence-core/tests/persisted-demand-coverage-campaign-oracle.test.ts. This change repairs campaign execution and mutant targeting; it preserves the existing model, history grammar, comparisons and reach requirements. P22 removes the covered-wait abort listener while retaining upstream promise settlement; an exact-target probe confirms it matches once and changes the source.Validation at
eb83d26e3:2102and captured nightly seed-1145433908, 580 histories each, 1,160 total. All 15 reach requirements pass in both campaigns; the least frequent reached state occurs in 51 and 50 histories, respectively. Suite: 10 tests passed, no type errors, 1,790 seconds total.Reproduce the long campaign:
node scripts/ci-tests.mjs build sqlite-core TANSTACK_DB_ORACLE_RUNS_MULTIPLIER=10 \ TANSTACK_DB_ORACLE_SEED=-1145433908 \ TANSTACK_DB_ORACLE_REACH_REPORT=1 \ pnpm --filter @tanstack/db-sqlite-persistence-core exec vitest run \ --coverage.enabled=false tests/persisted-demand-coverage-campaign-oracle.test.ts \ --disableConsoleIntercept node scripts/demand-coverage-mutants.mjsThe earlier release test and benchmark runs were fixed by merged #2359. This PR addresses nightly run 42232862302. It repairs execution setup and time allowance without changing the persisted-demand law, model, histories, driver, or oracle judgment. The evidence covers the existing controlled-core histories and observations; it adds no provider, framework, or multi-tab coverage claim. The historical red runs remain red; replacement checks validate this head.
✅ Checklist
🚀 Release Impact
Summary by CodeRabbit