Skip to content

Export atof symbol - #597

Merged
KenVanHoeylandt merged 1 commit into
mainfrom
add-symbol
Jul 28, 2026
Merged

Export atof symbol#597
KenVanHoeylandt merged 1 commit into
mainfrom
add-symbol

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved runtime compatibility by enabling support for resolving the atof conversion function on ESP-based platforms.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Added atof to the ESP platform’s main_symbols ELF export list, allowing the existing runtime symbol resolver to return it.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely matches the change: exporting the atof symbol.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-symbol

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KenVanHoeylandt KenVanHoeylandt changed the title Add atof symbol Export atof symbol Jul 28, 2026
@KenVanHoeylandt
KenVanHoeylandt merged commit 6e55e71 into main Jul 28, 2026
0 of 15 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the add-symbol branch July 28, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant