Improvements and fixes

[KenVanHoeylandt]

• Fix BluetoothSettings app not updating when toggling on Bluetooth on
• Fix BluetoothSettings app crash when closing while scanning
• Fix BluetoothSettings app crash when turning BT off while scanning
• WebServer doesn't save config anymore as a side-effect of reading the config
• Add missing license headers
• Use TactilityKernel's time and delay functions instead of TactilityFreeRtos ones

Summary by CodeRabbit

• Bug Fixes
  • Improved Bluetooth lifecycle handling so device updates remain consistent when toggling Bluetooth.
  • Safer BLE scanning/peer resolution during radio shutdown to avoid connect/race issues.
  • More consistent delays/timers across boot, idle services, screenshot capture, and button debounce for steadier UI behavior.
• Settings
  • Web server credentials and first-boot defaults are now generated/used in memory and only saved when you explicitly save.
• Documentation
  • Removed completed items from the ideas list.
  • Added SPDX license identifiers to shared icon headers.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The changes migrate timing calls across device, boot, application, service, and FreeRTOS wrapper code, adding MAX_TICKS and renaming the FreeRTOS-specific limit. Bluetooth management now tracks callback registration, invalidates dispatched events, and guards BLE scan resolution during radio shutdown. Web server-generated credentials and first-boot defaults are no longer automatically persisted. Headers, tests, and documentation are also updated.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 17.14% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title is too generic and does not convey the main change in the pull request.	Use a concise, specific title that names the primary change, such as Bluetooth settings, web server config persistence, or FreeRTOS timing cleanup.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

Tactility/Source/service/displayidle/DisplayIdle.cpp (1)

16-16: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Include tactility/time.h directly for millis_to_ticks.

The shown include block adds tactility/delay.h but not tactility/time.h, while line 226 uses millis_to_ticks. If the omitted lines 1–3 do not already include it, this relies on a transitive include and can break compilation when that dependency changes.

Proposed fix

 `#include` <tactility/delay.h>
+#include <tactility/time.h>

Also applies to: 226-226

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 298e54e7-a448-4ae3-b43c-a11916a9a65b

📥 Commits

Reviewing files that changed from the base of the PR and between e6e1dcd and b61a7a3.

📒 Files selected for processing (21)

• Devices/lilygo-tdeck/source/module.cpp
• Devices/unphone/source/drivers/unphone_nav_buttons.cpp
• Documentation/ideas.md
• Modules/lvgl-module/include/lvgl/icons/launcher.h
• Modules/lvgl-module/include/lvgl/icons/shared.h
• Modules/lvgl-module/include/lvgl/icons/statusbar.h
• Tactility/Private/Tactility/app/btmanage/BtManagePrivate.h
• Tactility/Source/SystemEvents.cpp
• Tactility/Source/app/alertdialog/AlertDialog.cpp
• Tactility/Source/app/boot/Boot.cpp
• Tactility/Source/app/btmanage/BtManage.cpp
• Tactility/Source/app/gpssettings/GpsSettings.cpp
• Tactility/Source/app/power/Power.cpp
• Tactility/Source/app/systeminfo/SystemInfo.cpp
• Tactility/Source/lvgl/Statusbar.cpp
• Tactility/Source/service/displayidle/DisplayIdle.cpp
• Tactility/Source/service/keyboardidle/KeyboardIdle.cpp
• Tactility/Source/service/screenshot/ScreenshotTask.cpp
• Tactility/Source/service/wifi/Wifi.cpp
• Tactility/Source/settings/WebServerSettings.cpp
• TactilityKernel/include/tactility/time.h

💤 Files with no reviewable changes (1)

• Documentation/ideas.md

[coderabbitai]

Actionable comments posted: 2

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4d98082d-02b5-428e-938a-d8be971139c2

📥 Commits

Reviewing files that changed from the base of the PR and between b61a7a3 and fb9a7af.

📒 Files selected for processing (12)

• Platforms/platform-esp32/source/drivers/bluetooth/esp32_ble_scan.cpp
• Tactility/Private/Tactility/app/btmanage/BtManagePrivate.h
• Tactility/Source/app/btmanage/BtManage.cpp
• TactilityFreeRtos/Include/Tactility/Dispatcher.h
• TactilityFreeRtos/Include/Tactility/DispatcherThread.h
• TactilityFreeRtos/Include/Tactility/EventGroup.h
• TactilityFreeRtos/Include/Tactility/Lock.h
• TactilityFreeRtos/Include/Tactility/PubSub.h
• TactilityFreeRtos/Include/Tactility/Thread.h
• TactilityFreeRtos/Include/Tactility/Timer.h
• TactilityFreeRtos/Include/Tactility/kernel/Kernel.h
• TactilityKernel/include/tactility/time.h

🚧 Files skipped from review as they are similar to previous changes (1)

• TactilityKernel/include/tactility/time.h