Repository navigation
Release ShiftInput 0.3.0 - #2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a shortcut-bypass feature set for remote-desktop apps and games, including automatic detection and per-application override controls, and bumps the project version for the 0.3.0 release.
Changes:
- Introduce
ApplicationBypassPolicy(ShiftInputCore) to decide when to bypass Shift / Shift+Space based on app metadata and heuristics. - Add per-app bypass settings (two independent switches) surfaced in both the status-bar menu and the Preferences UI, backed by new
SettingsStorekeys + migration. - Update documentation (ZH-TW/ZH-CN/EN) and release version/build examples to 0.3.0; extend
make testchecks to cover new logic.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| VERSION | Bumps release version to 0.3.0. |
| Sources/ShiftInputCore/ApplicationBypassPolicy.swift | New centralized policy for automatic/manual shortcut bypass decisions. |
| Sources/ShiftInput/StatusBarController.swift | Adds menu toggles for automatic bypass + “current app” bypass, and updates menu state on open. |
| Sources/ShiftInput/SettingsStore.swift | Persists automatic bypass + per-app bypass lists, includes migration for early test builds. |
| Sources/ShiftInput/PreferencesWindowController.swift | Adds bypass settings section with per-app list UI and independent shortcut toggles. |
| Sources/ShiftInput/GlobalKeyboardMonitor.swift | Adds shouldHandleShiftTap gating for Shift-tap action. |
| Sources/ShiftInput/ForegroundApplicationInfo.swift | New model for foreground app metadata used by bypass policy/UI. |
| Sources/ShiftInput/AppDelegate.swift | Tracks foreground app, wires bypass policy into keyboard monitor decisions and status-bar UI. |
| Scripts/StateMachineChecks.swift | Adds checks for bypass policy behavior and settings migration/defaults. |
| README.zh-CN.md | Documents bypass feature and updates build examples/version. |
| README.md | Documents bypass feature and updates build examples/version. |
| README.en.md | Documents bypass feature and updates build examples/version. |
| Makefile | Extends state-machine checks build to include SettingsStore. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+129
to
+133
| private func rememberForegroundApplication(_ application: NSRunningApplication?) { | ||
| guard let application, | ||
| let info = ForegroundApplicationInfo(runningApplication: application) else { return } | ||
| foregroundApplication = info | ||
| } |
Comment on lines
+212
to
+218
| private func refreshExcludedApps() { | ||
| excludedBundleIDs = settings.excludedApplicationBundleIDs.sorted { | ||
| displayName(for: $0).localizedCaseInsensitiveCompare(displayName(for: $1)) == .orderedAscending | ||
| } | ||
| excludedAppsTable.reloadData() | ||
| removeExcludedAppButton.isEnabled = excludedAppsTable.selectedRow >= 0 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
make test— 33 checks passedx86_64 arm64)