ci(site): start Chrome in the smoke test without depending on its stderr - #74
Merged
Merged
Conversation
The deploy after #73 failed before publishing: the smoke test waited 20s for Chrome to print its DevTools address on stderr, and on that runner it printed nothing at all. The same test passed on the pull request, so this was the start-up, not the site. The test now picks a free port itself and polls Chrome's /json/version until it answers, up to a minute per attempt, and starts a fresh Chrome up to three times if one stalls or exits, printing what happened. It also passes --disable-dev-shm-usage, the usual guard for a small /dev/shm on CI machines. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site deploy after #73 failed before anything was published. The smoke test waited 20 s for Chrome to print its DevTools address on stderr, and on that runner Chrome printed nothing. The same test passed on #73's own PR run, so the problem was Chrome's start-up, not the site. The live site is fine: it still serves the previous build.
What changed in
scripts/smoke_site.mjshttp://127.0.0.1:<port>/json/versionuntil Chrome answers, instead of parsing Chrome's stderr.--disable-dev-shm-usage, the usual guard against a small/dev/shmon CI machines.Checked: all six checks pass locally against a fresh build. Merging this also redeploys
main, which ships #73.🤖 Generated with Claude Code