ci: stop running every pull request twice - #2
Merged
Merged
Conversation
A branch pushed to origin and then opened as a pull request fired both the push and the pull_request trigger, so all four jobs ran twice on every pull request. Thirteen checks appeared on the first one where seven would have done. The push trigger is now restricted to main, which is the only branch where a push is not already covered by a pull request. pull_request stays unfiltered so a request from any branch, including a fork, is still checked. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1 showed thirteen checks. Four of them were duplicates: a branch pushed to
origin and then opened as a pull request fires both the
pushand thepull_requesttrigger, andci.ymlfiltered neither, so all four matrix jobsran twice.
The
pushtrigger is now restricted tomain, the only branch where a push isnot already covered by a pull request.
pull_requeststays unfiltered so arequest from any branch or fork is still checked.
This pull request is its own test: it should show four CI jobs rather than
eight. A direct push to
mainstill runs the gate, which is verified aftermerge.