docs(contributing): say that CodeQL and Socket are advisory, not gates - #12
Merged
Merged
Conversation
Neither is a required check, which was true by omission and therefore not communicated. The first contributor to see a Socket warning would either panic or click past it, and neither is the intent. States which checks gate a merge (the four CI jobs), that the advisory ones are deliberately not gates because a supply-chain advisory is a human judgement call, and what to actually do with one: a package that has started running install scripts or reaching the network is a real signal even with no CVE, and the conclusion belongs in the pull request. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither CodeQL nor Socket Security is a required check. That was true by omission, so nobody reading CONTRIBUTING would know it.
Adds one paragraph under the pull request flow: the four CI jobs gate a merge, the advisory checks deliberately do not, and a Socket alert on a dependency change is the one worth stopping for because it is the case that tooling is genuinely good at. Says plainly that clicking past it silently is the failure mode, and so is panicking at a transitive dependency's changelog.
Docs only.