fix(examples): redesign shader-node-group as five dipped-glaze stoneware mugs - #276
Merged
Merged
Conversation
…are mugs The gallery review judged the hero programmer art: two plain glossy spheres, teal and magenta, with nothing to show that a shared group was doing any work. The group is now a designed DippedGlaze stoneware shader. It has bare buff clay at the foot, a noise-wobbled dip line, iron speckle, and a glaze that breaks back toward clay over the rim. It is instanced in five mug materials (oxblood, amber, celadon, teal, cobalt). The mugs are lathed with a foot ring, bellied wall and rolled lip, with a swept oval handle. They stand as a staggered shop-display lineup on a walnut riser. Every mug carries the same foot band, dip line and speckle field. Only the instance Tint differs, which is the grouping contract made visible. The check is at least as strict as before. users must equal the number of materials (5, was 2), and all instance Tints must be pairwise distinct (was a single a != b). --same-tint still lands on exit 6. The stage now has the house wedge, and the key spread is narrowed off the back wall. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Signed-off-by: TMHSDigital <[email protected]>
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Signed-off-by: TMHSDigital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The gallery review judged the
shader-node-grouphero programmer art: two plain glossy spheres, teal and magenta. The render did not show a shared group doing any work.The redesign turns "one group, many tints" into a small glaze library:
DippedGlaze, a designed stoneware shader. It has bare buff clay at the foot, a wavy dip line (Generated Z against object-space noise), iron speckle (Voronoi) through clay and glaze alike, a glaze that breaks back toward clay over the rim, and a coat only on the glazed part. All of this lives inside the group. The interface still exposes onlyTint,RoughnessandShader.Before/after: the contact sheet is committed at
docs/gallery/contact-sheets/shader-node-group-contact-sheet.webp. The before is the two-sphere hero onmain.Check contract: at least as strict as before
users == 2users == len(mugs)(5)a != bGate numbers (5.2.1)
framing_ok.measure_hero_drift.py --only shader-node-group: mean_abs 0.00315, matches.render_hero.py.Check runs
--same-tint--outputrender.scratch/blender-5.2.1-windows-x64/blender.exe(Blender 5.2.1 LTS).scratch/blender-5.1.2-windows-x64/blender.exe(Blender 5.1.2).scratch/blender-4.5.11-windows-x64/blender.exe(Blender 4.5.11 LTS)Falsifiers (5.2.1)
--same-tintgives exit 6:instance Tint values not pairwise distinct [(0.42, 0.035, 0.03, 1.0) x5].group users 6 != 5 (not shared).tree.copy(), plus a stray user so the count stays 5. This gives exit 5:Mug.Celadon instance points at a different tree. Without the stray user, gate 4 fires first (users 4 != 5).Proven by live run vs established by inspection
Proven by live run:
--same-tinton 5.2.1, 5.1.2 and 4.5.11.render_hero.py,contact_sheet.pyandmeasure_hero_drift.pyon 5.2.1.build_gallery.py. The generated<img alt>indocs/gallery/index.htmlanddocs/gallery/shader-node-group/index.htmlwas read back, and so were theusers == 5witnesses.By inspection only:
🤖 Generated with Claude Code