fix(examples): redesign gn-modifier-inputs as three GN spiral staircases - #274
Merged
Merged
Conversation
The gallery review judged the hero programmer art: three plain cubes of different size and colour, the largest cropped and flat-lit. The shared Geometry Nodes tree now builds a parametric spiral staircase from its one Float input (renamed Scale -> Height; still Socket_1): step count = round((Height - 0.3) / 0.1), oak treads with brass balusters instanced up a helix, a teal newel post and a brass helical handrail. Heights 1/2/3 m give 7/17/27 treads, so the three modifiers on one tree read left to right as one design at three settings of one input. A lost write collapses a tall staircase to the 7-step default, which the render would show. The check contract is unchanged: shared node_group, per-version write path (dict on 4.5/5.1, mod.properties.inputs on 5.2), readback, evaluated Z-extent == written value (the newel post spans exactly [0, Height]), zmin == 0, distinct extents. --same-height is the falsifier flag; --same-scale stays as an alias. Lighting: shaped key (36 deg spread) and a high rim so the foreground floor stays dark. Adds an asset-sheet SELECT row. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Signed-off-by: TMHSDigital <[email protected]>
Union of asset-sheet SELECT rows; generated gallery pages regenerated. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Signed-off-by: TMHSDigital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The gallery review judged the
gn-modifier-inputshero programmer art: three plain cubes (teal/orange/pink), the largest one cropped and flat-lit. This is a redesign, not a touch-up.The shared Geometry Nodes tree now builds a parametric spiral staircase from its one Float input (renamed
Scale→Height; the identifier is stillSocket_1):round((Height − 0.3) / 0.1), and the riser is re-derived so the top tread lands exactly[0, Height]Heights 1 / 2 / 3 m give 7 / 17 / 27 treads. The three staircases read left to right as one design at three settings of one input. All three share one tree and one set of materials, so the modifier input is the only thing that differs. A lost write drops a staircase back to the 7-step default, which the render would show.
Stage: the default dark studio. The key has a 36° spread and the rim sits high behind the stairs, so the foreground floor stays dark (the old low rim was washing it blue). There are no labels.
Before / after
docs/gallery/contact-sheets/gn-modifier-inputs-contact-sheet.webpdocs/gallery/asset-sheets/gn-modifier-inputs.webpgn-modifier-inputs-hero.webponmain)Gate numbers (5.2.1 LTS, EEVEE)
matchesContact-sheet verdicts:
Mean luma is 0.221, against a calibration range of 0.151–0.279.
Asset sheet verdict: pass. The tall staircase is small in its panel because it is a tall, thin subject. With named parts, three materials, bevelled treads and a continuous rail, it is not the least-designed object beside the hydrant, drone, well, wheelbarrow and shelf. I added a SELECT row in
scripts/asset_sheet.pyfor it.Check runs (proven by live run)
Each binary reports its version via
--version:run_example.py)--same-height--same-scale--api dict--api rnaE:\Blender-Developer-Tools\.scratch\blender-5.2.1-windows-x64\blender.exeTypeError: … id properties not supported for this type…\blender-5.1.2-windows-x64\blender.exeAttributeError: 'NodesModifier' object has no attribute 'properties'…\blender-4.5.11-windows-x64\blender.exe--same-heightfails withreadback 1.0 != written 2.0 on SpiralStair.H2.Falsifier for the geometry-bearing check (exit 8): I set
RAIL_H = -0.5via an import probe, which makes the treads climb 0.5 m past the newel post. It fails on both 5.2.1 and 4.5.11 with exit 8:evaluated Z-extent 1.934334 != height 1.0 on SpiralStair.H1. Nothing was changed in the file; the probe was a scratch script.The check contract itself is unchanged: shared
node_group(4), per-version write and read (5/6), readback (7), extent == written value (8), zmin == 0 (9), distinct extents (11).Proven by live run vs established by inspection only
matches;build_gallery.py. I also read the generated<img alt>indocs/gallery/index.htmlanddocs/gallery/gn-modifier-inputs/index.htmland the witnesses callout.🤖 Generated with Claude Code