fix(examples): redesign sky-texture-sun-elevation hero as a sky-lit obelisk diptych - #263
Merged
Merged
Conversation
…belisk diptych The gallery review found the old hero broke Layer 1. The horizon band clipped to pure white under Standard, the frame was a hard split with a black void below the horizon, and the subject was a primitive cone. The still is now a sky study: a red-granite gnomon obelisk with a stepped limestone plinth, bronze collar and plaque, and a matte-gilt pyramidion. It stands on a brick-pattern plaza with a bronze meridian scale, and the ground runs to the horizon. The sky is the only light. Both panels use one Background Strength, so sun_elevation is the only variable between them: 8 deg is navy dusk with a horizon glow and a raked orange face, and 55 deg is blue midday with a short shadow. The render path now gates framing per panel through gallery_framing (exit 10) and gates clipped highlights under Standard (new exit 12, > 0.05 % of pixels). The committed still has zero clipped pixels. The check-only path is unchanged, and the sky_type, dust/aerosol and zenith-rise checks pass on 4.5.11, 5.1.2 and 5.2.1. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Signed-off-by: TMHSDigital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The gallery review found that the
sky-texture-sun-elevationhero broke Layer 1 in three ways:The redesigned still is a sky study. A red-granite gnomon obelisk (stepped limestone plinth, bronze collar, bronze dedication plaque, matte-gilt pyramidion) stands on a brick-pattern limestone plaza with a bronze meridian scale inlaid along the shadow line. The ground runs to the horizon, so there is no void below it.
sun_elevationis the only variable. If it failed, the panels would be identical.New render-path gates (the check-only path and CI smoke are unchanged):
gallery_framing.check_framingfor each panel (exit 10). The README's old "Framing deviation" is removed, and the helper's docstring no longer says this example skips it.Two root causes found along the way:
sun_rotationis a compass bearing, clockwise from +Y. The first draft assumed the opposite and put the shadow on the wrong side;_sun_rotation_for_shadownow holds the measured mapping.Before / after
Contact sheet (committed):
docs/gallery/contact-sheets/sky-texture-sun-elevation-contact-sheet.webpGate numbers (5.2.1)
measure_hero_drift.py)Contact-sheet verdicts. This is a stage deviation, so luminance is information only:
Check runs (check-only path,
tests/smoke/run_example.py --forbid-skip)E:\Blender-Developer-Tools\.scratch\blender-5.2.1-windows-x64\blender.exeE:\Blender-Developer-Tools\.scratch\blender-5.1.2-windows-x64\blender.exeE:\Blender-Developer-Tools\.scratch\blender-4.5.11-windows-x64\blender.exeThe
--outputrender path also exits 0 on all three binaries with zero clipped pixels (4.5.11 panel luma 0.087 / 0.200).Falsifiers (5.2.1)
--unlink-skygives exit 6:world links broken (sky→bg=False, bg→out=True).STILL_STRENGTH0.035 → 0.05 in a temporary copy gives exit 12: clip fraction 0.020344 (8° panel 0.008019, 55° panel 0.033383), and no PNG is written. The copy was then removed.Proven by live run vs established by inspection only
Proven by live run:
render_hero.py,contact_sheet.py,measure_hero_drift.pyandbuild_gallery.py.<img alt>indocs/gallery/index.htmlanddocs/gallery/sky-texture-sun-elevation/index.htmlwas read back.Established by inspection only:
blender-smoke.yml) has not run yet; this PR relies on its run.Not wired:
gallery_asset_quality(exit 11). Perdocs/VISUAL-STYLE.mdit applies to asset-type examples, not world/sky subjects.🤖 Generated with Claude Code