Skip to content

Fix direct console logging warnings - #32

Merged
ryanbarlow97 merged 1 commit into
mainfrom
fix/plugin-console-logging
Sep 25, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
fix/plugin-console-logging

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Paper reports TLibs for writing directly to System.out during startup. RebuildDebug now emits each message once through the plugin logger, preserving the debug toggle and unconditional startup messages. A JUL fallback keeps logging available without a plugin instance.

Validation: Java 21 Maven clean verify passed (20 tests), runtime JAR verification passed, and the source scan found no active System.out/System.err calls. Live server validation has not been performed.

Summary by CodeRabbit

  • Improvements
    • Debug messages now use the configured logger, with a standard logging fallback when the plugin logger is unavailable.
    • Log messages now use the [MMORebuild] label instead of [TLibs].

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 01f722e9-ce8f-4c88-a60e-c73c106208e9

📥 Commits

Reviewing files that changed from the base of the PR and between 7d1280e and a0704d1.

📒 Files selected for processing (1)
  • src/main/java/net/tfminecraft/tlibs/utils/RebuildDebug.java

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The debug logging methods now send messages through a single logger call. The code uses the plugin logger when available and a named Java logging fallback otherwise. The message prefix changes to [MMORebuild].

Changes

Rebuild debug logging

Layer / File(s) Summary
Logger selection and message formatting
src/main/java/net/tfminecraft/tlibs/utils/RebuildDebug.java
log delegates to logAlways. logAlways selects the plugin logger or a named Java logging fallback, and uses the [MMORebuild] prefix.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to a0704

This changes how debug messages are emitted, with no concrete regression established. The change is mergeable subject to routine checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: replacing direct console logging in RebuildDebug with logger-based output to remove warnings.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the log at night
The plugin logger writes it right
If none is there, a fallback calls
One message travels through the halls
“MMORebuild,” the label reads
Then off the rabbit quietly speeds

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit 13f4e9d into main Sep 25, 2026
4 checks passed
@ryanbarlow97
ryanbarlow97 deleted the fix/plugin-console-logging branch September 25, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant