Skip to content

Allow ascended ranks to upload mask skins - #24

Merged
Drefvelin merged 1 commit into
mainfrom
mask-skins
Sep 23, 2026
Merged

Drefvelin merged 1 commit into
mainfrom
mask-skins

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds mask to the ascended skin-kind list so skin tokens include custom 3D masks.
  • Legacy still inherits it through the lower-tier union.

Test plan

  • After reload, an ascended player's skin entitlements include mask.
  • A noble token still cannot upload mask.

Made with Cursor

Summary by CodeRabbit

  • New Features
    • Ascended skins can now use the mask skin kind. All previously supported skin kinds remain available, so existing options are unchanged.

The mask kind follows the same rank gate as other 3D helmet submissions.

Co-authored-by: Cursor <[email protected]>
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f6dcccb5-a1e7-4ed3-9f2b-987c34422550

📥 Commits

Reviewing files that changed from the base of the PR and between 28be07d and d30243b.

📒 Files selected for processing (1)
  • src/main/resources/config.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The Ascended group’s configured skin-kinds list now includes mask. Its existing entries remain unchanged.

Changes

Ascended skin kinds

Layer / File(s) Summary
Update Ascended skin kinds
src/main/resources/config.yml
The Ascended group’s skin-kinds list adds mask and retains its existing entries.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: carolinebondhus

Merge Risk: ⚪ Minimal · up to d3024

Reloaded entitlements include mask for Ascended and higher players, while Noble-only players remain excluded. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: allowing ascended ranks to upload mask skins.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the kinds in line,
Finds mask added to the design.
The other entries stay in place,
One small change in config’s space.
It hops away beneath the moon.

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit 877f722 into main Sep 23, 2026
2 checks passed
@Drefvelin
Drefvelin deleted the mask-skins branch September 23, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant