refactor: remove features transferred to their owning plugins

[ryanbarlow97]

Remove inventory scanning, character focus and letter implementations from Core. TLibs, RPCharacters and BirdMessenger own those features; Cooking, Magic and Research use the owners directly. Core retains server rules, drops, stations, statistics, whistles and stones.

Remove the transferred API packages and focus/letters command branches rather than leaving wrappers or aliases. Focus administration is /focus in RPCharacters; letter reload is part of /birdmessenger reload. No migration tooling or version-detection code is added. Server configuration/data is copied manually during the coordinated dev/main update documented in Docs.

Validation: clean Maven verify passed 168 tests (baseline 172; the four letter-config tests moved to BirdMessenger). Runtime JAR checks passed, including absence of the transferred packages. This removal no longer needs new provider versions to compile. Deploy the full matching plugin set together to retain all features.

Coordinated PRs

1. Scanner: TLibs #30, Cooking #41.
2. Focus: RPCharacters #27, Research #4, Magic #24 (also scanner).
3. Letters: BirdMessenger #24.
4. Core removal and manual update guide: TFMCCore #24, Docs #45.

TLibs 2.1.0 and RPCharacters 2.1.0 are published with verified release artifacts. No server deployment has been performed.

Summary by CodeRabbit

• Changes
  • Removed character focus and sealed-letter features, including their configuration and related administration commands.
  • Removed item scanning functionality.
  • Updated the project description to reflect its remaining gameplay features and server rules.
  • Whistle, Stones, and Stats lifecycle handling remains unchanged.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 65bbc369-eea2-4c98-a1a1-06fd23a2ae0f

📥 Commits

Reviewing files that changed from the base of the PR and between 9dfb632 and e940ab3.

📒 Files selected for processing (22)

• README.md
• src/main/java/net/tfminecraft/tfmccore/TFMCCore.java
• src/main/java/net/tfminecraft/tfmccore/commands/CoreCommands.java
• src/main/java/net/tfminecraft/tfmccore/commands/CoreTabCompletion.java
• src/main/java/net/tfminecraft/tfmccore/focus/FocusAttributes.java
• src/main/java/net/tfminecraft/tfmccore/focus/FocusConfig.java
• src/main/java/net/tfminecraft/tfmccore/focus/FocusConfigLoader.java
• src/main/java/net/tfminecraft/tfmccore/focus/FocusData.java
• src/main/java/net/tfminecraft/tfmccore/focus/FocusListener.java
• src/main/java/net/tfminecraft/tfmccore/focus/FocusService.java
• src/main/java/net/tfminecraft/tfmccore/focus/FocusStore.java
• src/main/java/net/tfminecraft/tfmccore/focus/RpCharactersBridge.java
• src/main/java/net/tfminecraft/tfmccore/itemscan/ItemScanHandler.java
• src/main/java/net/tfminecraft/tfmccore/itemscan/ItemScanService.java
• src/main/java/net/tfminecraft/tfmccore/letters/LetterConfig.java
• src/main/java/net/tfminecraft/tfmccore/letters/LetterConfigLoader.java
• src/main/java/net/tfminecraft/tfmccore/letters/LetterItems.java
• src/main/java/net/tfminecraft/tfmccore/letters/LetterListener.java
• src/main/resources/focus.yml
• src/main/resources/letters-config.yml
• src/main/resources/plugin.yml
• src/test/java/net/tfminecraft/tfmccore/letters/LetterConfigLoaderTest.java

💤 Files with no reviewable changes (18)

• src/main/resources/letters-config.yml
• src/main/java/net/tfminecraft/tfmccore/focus/FocusConfig.java
• src/test/java/net/tfminecraft/tfmccore/letters/LetterConfigLoaderTest.java
• src/main/resources/focus.yml
• src/main/java/net/tfminecraft/tfmccore/itemscan/ItemScanService.java
• src/main/java/net/tfminecraft/tfmccore/letters/LetterConfigLoader.java
• src/main/java/net/tfminecraft/tfmccore/focus/FocusAttributes.java
• src/main/java/net/tfminecraft/tfmccore/itemscan/ItemScanHandler.java
• src/main/java/net/tfminecraft/tfmccore/letters/LetterConfig.java
• src/main/java/net/tfminecraft/tfmccore/focus/FocusConfigLoader.java
• src/main/java/net/tfminecraft/tfmccore/focus/FocusService.java
• src/main/java/net/tfminecraft/tfmccore/focus/FocusListener.java
• src/main/java/net/tfminecraft/tfmccore/letters/LetterListener.java
• src/main/java/net/tfminecraft/tfmccore/focus/RpCharactersBridge.java
• src/main/java/net/tfminecraft/tfmccore/letters/LetterItems.java
• src/main/java/net/tfminecraft/tfmccore/focus/FocusData.java
• src/main/java/net/tfminecraft/tfmccore/focus/FocusStore.java
• src/main/java/net/tfminecraft/tfmccore/TFMCCore.java

Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The change removes Focus, letter handling, and item scanning. Core lifecycle and configuration handling no longer include these components. Related commands, tab completions, plugin usage text, resources, tests, and README entries are removed or updated.

Changes

Removed integrations

Layer / File(s)	Summary
Focus state and regeneration removal src/main/java/net/tfminecraft/tfmccore/focus/*, src/main/resources/focus.yml	Focus configuration, state, persistence, character integration, event handling, and service code are deleted.
Letter handling removal src/main/java/net/tfminecraft/tfmccore/letters/*, src/main/resources/letters-config.yml, src/test/java/net/tfminecraft/tfmccore/letters/*	Letter configuration, item creation, book event handling, resources, and loader tests are deleted.
Item scanning removal src/main/java/net/tfminecraft/tfmccore/itemscan/*	The item scan handler interface and service are deleted, including inventory and pickup scanning.
Core wiring and command updates src/main/java/net/tfminecraft/tfmccore/TFMCCore.java, src/main/java/net/tfminecraft/tfmccore/commands/*, src/main/resources/plugin.yml, README.md	Core startup, shutdown, and configuration handling no longer include the removed components. Their command handling, tab completions, usage text, and README entries are removed or updated.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Suggested reviewers: justinasla

Merge Risk: ⚪ Minimal · up to e940a

Core is ready for normal checks, provided the matching plugins are deployed together and existing configuration and data are transferred as planned.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 2 files. (2 skipped: 2…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the primary change: removing features from Core after transferring them to their owning plugins.

Full details: Docstring Coverage

Explanation

Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 2 files. (2 skipped: 2 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{A rabbit checks the garden gate
Three paths grow quiet, cleared of code
The config leaves its burrow neat
Commands now point to fewer trails
Soft paws applaud the tidy page}

_{Comment @coderabbitai help to get the list of available commands.}