refactor: remove dev-characters and the dev character tag - #59
Merged
Merged
Conversation
dev-characters kept a server from syncing characters with its website and tagged characters made in game as "dev", so pre-season staff tests stayed off the main site and could be deleted with /rpcharacter wipe tagged. Dev now has its own dev website with realm dev, so that isolation is no longer needed. Remove the setting, the tag and the tagged wipe. Every server now pulls pending creates and kit customisations and pushes its full roster to its own site. The website realm wipe is unchanged. Existing "dev" keys in character files are ignored. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (15)
💤 Files with no reviewable changes (9)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe change removes the development-character setting and character flag, and removes the tagged-character wipe action. Pull, roster, and kit flows no longer skip processing based on development-character mode. ChangesDevelopment-character mode removal
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to The change is mergeable after normal checks; no actionable merge-blocking risk was established. Security Architecture ReviewSecurity architecture risk: 🟡 Moderate · up to Removing the old isolation mode makes each server depend on its website realm for separation and allows previously tagged character files to enter normal roster sync. The stated rollout reduces the expected exposure, but realm enforcement and the absence of remaining tagged files have not been independently established. The website-wipe confirmation change does not appear to weaken its existing admin check. Retained concerns
Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
A rabbit peeks where dev flags lay, Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
dev-characterswas a pre-season tool. It stopped a server syncing characters with its website, and tagged characters made in game with"dev": "true". Staff tests on Dev then stayed off the main site, and/rpcharacter wipe taggedcould delete them.Since 23 September Dev has had its own dev website (dev.tfminecraft.net, realm
dev), so that isolation isn't needed any more.Changes
Removed:
dev-characterssetting and itsCachefield;devfield onRPCharacter, and reading and writing it in character files;CharacterCreation;dev-charactersguards inCharacterIngestService,KitCustomiseIngestService,KitServiceandRosterSyncService, and the/rpcharacter pending syncrefusal;/rpcharacter wipe taggedandCharacterWipeService, which only served it, along with its test./rpcharacter wipe websiteis unchanged apart from dropping the per-action confirm bookkeeping it no longer needs.Every server now pulls pending creates and kit customisations, and pushes its full roster to its own site. Existing
"dev"keys in character files are ignored.Effect on servers
dev-characters: falseand has no tagged characters (0 of 240), so nothing changes.dev-characters: falseearlier today, and Wonder, its only tagged character, was untagged. So nothing changes there either.The leftover
dev-characters:line in either server'sconfig.ymlis now unused and harmless.Docs: TF-Minecraft/Docs#70, which renames the page to the website realm wipe.
Testing
mvn verify: 285 tests pass.🤖 Generated with Claude Code
Summary by CodeRabbit
/rpcharacter wipecommand now supports only the website wipe action; tagged-character wipe is no longer available. Tab completion reflects the remaining action.