Skip to content

File patch notes by what players care about - #38

Merged
Drefvelin merged 1 commit into
mainfrom
fix/patchnote-section-structure
Sep 25, 2026
Merged

Drefvelin merged 1 commit into
mainfrom
fix/patchnote-section-structure

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • The deny rewrite treats New, Fixed, Adjusted, and Technical as the structure of the note: player-facing changes in the first three, backend work in Technical. A named section from staff still wins.
  • Incoming commits follow the same split, so a logger or migration written as a fix stays Technical, and a player-facing change to an existing feature stays Adjusted.

Test plan

  • pytest src/patchnotes/test_feedback.py src/patchnotes/test_summarize.py (18 passed)
  • Deny a week and confirm a backend line moves to Technical when the feedback asks for the structure

Made with Cursor

Summary by CodeRabbit

  • Bug Fixes
    • Patch notes now more accurately distinguish player-facing additions, fixes, and adjustments from technical changes.
    • Backend changes are classified as technical, even when commit messages use feature or fix labels.
    • Changes about player-facing features without a recognized commit label are categorized as adjustments.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ab4fcaf3-b023-4fc8-8f51-6d11d5ec1693

📥 Commits

Reviewing files that changed from the base of the PR and between 3e59732 and 385aea1.

📒 Files selected for processing (4)
  • backend/src/patchnotes/feedback.py
  • backend/src/patchnotes/summarize.py
  • backend/src/patchnotes/test_feedback.py
  • backend/src/patchnotes/test_summarize.py
 ________________________
< EV: Electric Verifier. >
 ------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit 2aa91d3 into main Sep 25, 2026
1 of 2 checks passed
@Drefvelin
Drefvelin deleted the fix/patchnote-section-structure branch September 25, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant