Skip to content

Let a long patch-note deny finish - #37

Merged
Drefvelin merged 1 commit into
mainfrom
fix/patchnote-feedback-rewrite
Sep 25, 2026
Merged

Drefvelin merged 1 commit into
mainfrom
fix/patchnote-feedback-rewrite

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • A deny rewrite now asks Claude for only the lines it changes or drops, so a long week no longer has to echo every bullet.
  • Staff section names win. New, fixed, adjusted, and technical follow the player-facing definitions, and a section move keeps the existing sentence.
  • The reply cap is 8000 tokens. If the model still stops there, the error says the rewrite was cut off.

Test plan

  • pytest src/patchnotes/test_feedback.py (9 passed)
  • Deny week 2026-W39 with the earlier feedback and confirm the section moves and drops land

Made with Cursor

Summary by CodeRabbit

  • Improvements
    • Patch note feedback now focuses on player-facing additions and fixes, with clearer guidance for choosing sections.
    • Unchanged lines can be left untouched, and moving a line between sections can retain its existing text.
    • Feedback is limited to three new lines.
  • Bug Fixes
    • Rewrites with a missing or blank replacement now retain the original text.
    • Truncated feedback responses are reported as cut off rather than as empty responses.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 45d9d82c-7342-49dc-ade6-4435a1723aec

📥 Commits

Reviewing files that changed from the base of the PR and between ff402f3 and 31e22a2.

📒 Files selected for processing (2)
  • backend/src/patchnotes/feedback.py
  • backend/src/patchnotes/test_feedback.py
 ______________________________________________________________________________________________________________________________________________________________________________________________________
< Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it. - Brian Kernighan >
 ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit 3e59732 into main Sep 25, 2026
1 of 2 checks passed
@Drefvelin
Drefvelin deleted the fix/patchnote-feedback-rewrite branch September 25, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant