Skip to content

Keep deny feedback from being published as the patch note line - #35

Merged
Drefvelin merged 1 commit into
mainfrom
fix/patchnote-feedback-is-not-the-line
Sep 25, 2026
Merged

Drefvelin merged 1 commit into
mainfrom
fix/patchnote-feedback-is-not-the-line

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • A per-line deny reason is no longer saved as the public wording when it is a sentence.
  • Only an explicit replacement, such as say: Added a station, becomes the new line. Whole-note feedback stays on POST /patchnotes/staff/weeks/{week}/feedback.

Test plan

  • python3 -m unittest backend/src/patchnotes/test_revise.py
  • Deny a line with a sentence that is not say: ... and confirm it is not published as the body.

Made with Cursor

Summary by CodeRabbit

  • Bug Fixes
    • Staff feedback that comments on an update or requests changes is no longer mistaken for replacement wording. Patch notes remain unpublished when no replacement text is provided.
    • Feedback covering multiple points is handled across the week’s update.

A deny reason is an instruction for the week's note. A sentence in that feedback is no longer saved as the replacement line.

Co-authored-by: Cursor <[email protected]>
@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6b10fde2-109b-4049-bb1a-97704788a0f0

📥 Commits

Reviewing files that changed from the base of the PR and between 9d8025a and 5dcf620.

📒 Files selected for processing (2)
  • backend/src/patchnotes/revise.py
  • backend/src/patchnotes/test_revise.py
 ___________________________________________________________
< Did you mean to handle errors, or just *experience* them? >
 -----------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit 9464947 into main Sep 25, 2026
1 of 2 checks passed
@Drefvelin
Drefvelin deleted the fix/patchnote-feedback-is-not-the-line branch September 25, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant