Offer lutes as a handheld and 3D skin type

[Drefvelin]

Summary

• Handheld (16×16) and Item 3D uploads can target lutes, the same way swords are an applicable type.
• The API accepts base_set=lutes for those two kinds and still rejects it for large handheld.

Test plan

• On dev, redeem a skin code, choose Handheld, and confirm Applicable type includes Lutes
• Choose Item 3D and confirm Lutes is listed there too
• Choose Large handheld and confirm Lutes is not listed
• Submit is not required for this check; the dropdown is the website change

Made with Cursor

Summary by CodeRabbit

• New Features
  • Added Lutes as an available base set for handheld and 3D item skins, labeled “Lutes” in the skin options.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a8e0cce1-64c8-403d-bc93-8f72e5b339bf

📥 Commits

Reviewing files that changed from the base of the PR and between 8ac8b2c and 226e430.

📒 Files selected for processing (1)

• backend/src/skins/test_base_sets.py

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.

---

📝 Walkthrough

Walkthrough

The backend validator and frontend base-set data now include lutes for handheld and item_3d. Tests check that large_handheld rejects it and that the frontend label is “Lutes.”

Changes

Lutes base-set support

Layer / File(s)	Summary
Register and validate the lutes base set frontend/lib/skins/baseSets.ts, backend/src/skins/submissions.py, backend/src/skins/test_base_sets.py, frontend/lib/skins/baseSets.test.ts	The frontend lists lutes for handheld and labels it “Lutes.” The backend accepts it for handheld and item_3d. Tests check these supported kinds and its rejection for large_handheld.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 226e4

This change adds Lutes for Handheld and Item 3D while keeping it unavailable for Large handheld. The supplied changes and tests show no merge-blocking issue.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding lutes as supported handheld and 3D skin types.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{A rabbit checks the base-set list,
Then marks each supported kind.
“Lutes” appears in friendly text,
While large_handheld leaves it behind.
The tests confirm each point in line.}

_{Comment @coderabbitai help to get the list of available commands.}