Skip to content

Describe config changes in words a player would recognize - #31

Merged
Drefvelin merged 1 commit into
mainfrom
clearer-patch-notes
Sep 24, 2026
Merged

Drefvelin merged 1 commit into
mainfrom
clearer-patch-notes

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • A display name that is only a template, such as {inherit} Filet, is rewritten from the entry key and any real override names.
  • A change is posted only when a player-facing field can be named. Internal edits, including a model id on a placeholder item, are dropped.

Test plan

  • pytest src/patchnotes/test_substance.py src/patchnotes/test_folders.py

Made with Cursor

Summary by CodeRabbit

  • New Features
    • Generated patch notes now recognize cooking options, cooking time, burning, freshness, and age as player-facing changes.
    • Entry titles can draw on available names and meaningful template details, while titles containing unresolved placeholders are excluded.
    • Changes to nested entries and named entries are described more clearly, including renames and combined field updates.
    • Generated descriptions with unresolved placeholders are omitted.

Template names such as {inherit} are read from the entry around them, and a line is dropped when the change still has no player-facing meaning.

Co-authored-by: Cursor <[email protected]>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e1e8e885-e7fd-4227-ae7a-d6084420ade6

📥 Commits

Reviewing files that changed from the base of the PR and between 19c0445 and 00f956a.

📒 Files selected for processing (2)
  • backend/src/patchnotes/substance.py
  • backend/src/patchnotes/test_substance.py
 ______________________________________________________________________________________________________
< What one programmer can do in one month, two programmers can do in two months. - Frederick P. Brooks >
 ------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit abe7d48 into main Sep 24, 2026
1 of 2 checks passed
@Drefvelin
Drefvelin deleted the clearer-patch-notes branch September 24, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant