Skip to content

fix: refresh the clicked slot without the reopened view #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XxFran10xX merged 1 commit into from
Sep 26, 2026
+8 −5
Merged

fix: refresh the clicked slot without the reopened view #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/main/java/net/tfminecraft/magic/listener/GearRefreshListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.player.PlayerDropItemEvent;
import org.bukkit.event.player.PlayerItemHeldEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;

import net.tfminecraft.magic.Magic;
Expand Down Expand Up @@ -39,16 +40,18 @@ public void onClick(InventoryClickEvent event) {
if (!(event.getWhoClicked() instanceof Player player)) {
return;
}
int rawSlot = event.getRawSlot();
// Keep the clicked inventory and its own slot index. The open view can change
// before next tick (a menu closes), so a raw view slot may no longer exist.
Inventory clicked = event.getClickedInventory();
int slot = event.getSlot();
later(() -> {
if (!player.isOnline()) {
return;
}
if (rawSlot >= 0 && rawSlot < player.getOpenInventory().countSlots()) {
ItemStack rebuilt = GearRefresher.refreshIfOutdated(
player.getOpenInventory().getItem(rawSlot), player);
if (clicked != null && slot >= 0 && slot < clicked.getSize()) {
ItemStack rebuilt = GearRefresher.refreshIfOutdated(clicked.getItem(slot), player);
if (rebuilt != null) {
player.getOpenInventory().setItem(rawSlot, rebuilt);
clicked.setItem(slot, rebuilt);
}
}
ItemStack cursor = GearRefresher.refreshIfOutdated(
Expand Down