Skip to content

feat: tell staff when gear materials are bypassed - #30

Merged
Drefvelin merged 1 commit into
mainfrom
feat/staff-craft-bypass-message
Sep 25, 2026
Merged

Drefvelin merged 1 commit into
mainfrom
feat/staff-craft-bypass-message

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • When magic.bypass_crafting_cost skips the materials for a prepared weapon, chat now says materials were bypassed due to staff.
  • The line is gear.craft.bypassed in messages.yml, so it can be reworded without a code change.

Test plan

  • Dev build succeeds
  • Prepare a weapon with magic.bypass_crafting_cost and confirm gold chat: "Materials were bypassed due to staff."
  • Prepare a weapon without that permission and confirm materials are still taken and the bypass line is absent

Made with Cursor

Summary by CodeRabbit

  • Updates
    • Staff crafting that bypasses material requirements now displays a message explaining that materials were bypassed.

Staff with the crafting-cost bypass were preparing weapons without paying, and nothing in chat said the materials had been skipped.

Co-authored-by: Cursor <[email protected]>
@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 820a3715-44f1-4bd3-82ce-863ea4596937

📥 Commits

Reviewing files that changed from the base of the PR and between f1e5d8f and ec28c52.

📒 Files selected for processing (2)
  • src/main/java/net/tfminecraft/magic/gear/gui/GearInventoryManager.java
  • src/main/resources/messages.yml
 _______________________________________________________________________________________
< If you don't fail at least 90% of the time, you're not aiming high enough. - Alan Kay >
 ---------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit bb71765 into main Sep 25, 2026
1 of 2 checks passed
@Drefvelin
Drefvelin deleted the feat/staff-craft-bypass-message branch September 25, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant