Skip to content

Damage committed players who leave a lure until they opt out - #6

Merged
Drefvelin merged 1 commit into
mainfrom
fix/lure-leave-damage
Sep 26, 2026
Merged

Drefvelin merged 1 commit into
mainfrom
fix/lure-leave-damage

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • A committed player who leaves the province stays in the lure and takes one heart of deserter damage per second, with a prompt to run /lure leave.
  • /lure leave drops that player from the fight and stops the damage. The lure fails only when nobody committed remains.
  • Walking back into the province stops the damage without dropping them.

Test plan

  • Place a lure, join, leave the province, and confirm the lure stays up while you take 1 heart per second and are told to run /lure leave.
  • Run /lure leave outside the province and confirm the damage stops and you are no longer in the fight.
  • With another player still committed, confirm their lure continues after you leave.
  • As the last committed player, confirm /lure leave fails the lure and the infestation remains.
  • Confirm a player who never joined still takes deserter damage only while they stay in the province after the lure starts.

Made with Cursor

Summary by CodeRabbit

  • New Features
    • Added /lure leave so players can leave a lure and stop taking damage for being outside the province.
    • Committed players who leave the province now receive ongoing damage and reminders instead of immediately failing the lure.
    • A lure fails if no living or grace-protected participants remain.
    • Bystanders who stay after a lure starts are warned and take damage.

Leaving the province used to fail the lure for the whole party. A committed player now takes deserter damage until /lure leave drops them from the fight.

Co-authored-by: Cursor <[email protected]>
@coderabbitai

coderabbitai Bot commented Sep 26, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 67dbe8a8-dc91-4864-81f1-c9511fc4efc0

📥 Commits

Reviewing files that changed from the base of the PR and between 8da0a34 and 2229348.

📒 Files selected for processing (7)
  • README.md
  • src/main/java/net/tfminecraft/infestations/Infestations.java
  • src/main/java/net/tfminecraft/infestations/command/CommandManager.java
  • src/main/java/net/tfminecraft/infestations/infestation/InfestationManager.java
  • src/main/resources/config.yml
  • src/main/resources/messages.yml
  • src/main/resources/plugin.yml
 ______________________________________________________________________
< I am here to kick bugs and chew carrots. And I'm all out of carrots. >
 ----------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit 9bb6c95 into main Sep 26, 2026
1 of 2 checks passed
@Drefvelin
Drefvelin deleted the fix/lure-leave-damage branch September 26, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant