chore: standardise repository for TFMC - #1
Merged
Merged
Conversation
Build on the shared Java 21 / Paper 1.21.10 baseline with the committed POM layout, pinned TFMC provider releases and checksum-verified private inputs from ServerAssets. Add the shared build and release workflows, artifact check, ignore rules, editor settings, licence and README. Move imports to the current lowercase provider packages, let Maven supply the plugin version, and normalise line endings to LF. Technical guides now live in TF-Minecraft/Docs. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the new Gathering repository in line with the other TFMC plugins.
paper-api:1.21.10-R0.1-SNAPSHOTwithmain-SNAPSHOTand the shared POM layout. The WindowssystemPathjars and the antrun copy step are removed.2.0.1and RPCharacters2.0.2, the latest releases, installed by the shared installer. MMOCore1.13.1and MythicLib1.7come from ServerAssets183a187and are checked against.github/dependencies.sha256. Gson comes from Paper.net.tfminecraft.tlibsandnet.tfminecraft.rpcharacterspackages. Biome names are looked up in Paper's registry instead of the removedBiome.valueOf, so unknown names still log a warning..gitignore,.editorconfig, Artistic-2.0 licence and README.version: '${project.version}'andapi-version: '1.21.10'.Docs: TF-Minecraft/Docs (Gathering guides, linked separately).
Validation
mvn clean verifypasses locally on Java 21.0.12 / Maven 3.9.11 with the pinned inputs; no unit-test suite..github/scripts/plugin-artifact.pyaccepts the runtime JAR; the embeddedplugin.ymlhas the Maven version andapi-version: '1.21.10', and the classes are Java 21 bytecode (major 65).-Dmaven.compiler.showDeprecation=true, the only warnings left are legacy string UI calls (setDisplayName,ChatColorand similar), which other TFMC plugins also still use.DEPS_TOKEN.Most of the diff is CRLF-to-LF normalisation. Review with whitespace hidden (
?w=1).Found during review, not changed here
/gathering reloaddoesn't restart the spawn, discovery or particle timers. Interval changes need a restart.spawnedAtMsis saved but never read, so a type that reachesmax-activestops spawning until its spots are gathered.getChunkAton the main thread, which also generates missing chunks within the bounds.🤖 Generated with Claude Code