Set the default chicken egg interval to one hour

[Drefvelin]

Summary

• Happy, mature chickens lay one egg per egg-timer in husbandry.yml, now 1h by default.
• A missing or unreadable husbandry config falls back to the same one-hour interval.

Documentation impact

• Central Cooking documentation: updated in TF-Minecraft/Docs docs/egg-timer-one-hour (default 1h).

Contract

• Affected behavior: owned chickens that are loaded, mature, and happy drop one cooking egg, then wait egg-timer (default one hour) before the next. Existing servers keep their current husbandry.yml until that file is updated.
• Tests run (mvn test, or why not): mvn -Dtest=EggIngredientTest test passed locally. Full verify runs on this pull request.
• Player wiki (ProvinceSystem /wiki/cooking or related pages): no change

Notes

• Config source is src/main/resources. Do not edit target/.
• plugin.yml version and pom.xml version are known drift. Do not mix a version bump into unrelated work.
• cookware.yml is not loaded.

Test plan

• Pull-request build (DEV-…) succeeds
• Dev server loads the built jar with egg-timer: 1h and Cooking enables
• Confirm a chicken's next egg is scheduled from that interval after the config is loaded

Made with Cursor

Summary by CodeRabbit

• Gameplay
  • Increased the interval between eggs from 10 minutes to 1 hour.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e7d3a8c2-c414-4974-9c86-10ef7010809b

📥 Commits

Reviewing files that changed from the base of the PR and between e7987b1 and 11bb854.

📒 Files selected for processing (4)

• src/main/java/net/tfminecraft/cooking/husbandry/HusbandryConfig.java
• src/main/java/net/tfminecraft/cooking/husbandry/HusbandryLoader.java
• src/main/resources/husbandry.yml
• src/test/java/net/tfminecraft/cooking/item/EggIngredientTest.java

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

The egg timer default and configuration change from 10 minutes to 1 hour. The loader accepts the updated duration, and a test checks that the configuration uses 1h instead of 10m.

Changes

Egg timer interval

Layer / File(s)	Summary
Egg timer defaults and configuration src/main/java/net/tfminecraft/cooking/husbandry/HusbandryConfig.java, src/main/java/net/tfminecraft/cooking/husbandry/HusbandryLoader.java, src/main/resources/husbandry.yml, src/test/java/net/tfminecraft/cooking/item/EggIngredientTest.java	The default and loader values increase to 3,600 seconds. The YAML interval changes to 1 hour and describes the chicken conditions. The test checks for egg-timer: 1h and against egg-timer: 10m.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested reviewers: ryanbarlow97

Merge Risk: ⚪ Minimal · up to 11bb8

The change sets the YAML interval to 1h and aligns the code defaults at 3,600 seconds. No concrete regression is established, though the server-provided parser's exact conversion was not verified.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 11bb8

The one-hour default changes egg timing for servers that use it, but the existing configuration access, eligibility checks, and saved egg-ready state remain in place. No new security boundary or material security concern was identified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The effective change is limited to timing within the existing husbandry path; the inspected caller and consumer do not show a new attacker-controlled input or privilege transition.

Trust Boundaries and Controls

• inferred — Configuration remains under the existing server-file and administrative reload controls. Repository evidence does not establish runtime filesystem permissions or permission assignments, but this PR does not change those controls.

Resilience and Maintainability Implications

• observed — Egg-ready timestamps remain persisted and restored, while the existing periodic tick invokes egg laying and saves dirty animal state; the interval edit does not change these recovery paths.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: increasing the default chicken egg interval to one hour.
Description check	✅ Passed	The description includes all required template sections and provides the affected behavior, documentation status, test command, player wiki status, and configuration notes. The additional test plan is…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{A rabbit checks the timer's face,
One hour marks the egg's slow pace.
The config joins the measured beat,
A test confirms the change complete.
I nibble greens and hop away.}

_{Comment @coderabbitai help to get the list of available commands.}