Skip to content

chore: pin CI to TLibs main and drop stale PR template note - #44

Merged
ryanbarlow97 merged 2 commits into
mainfrom
chore/remove-legacy-references
Sep 24, 2026
Merged

ryanbarlow97 merged 2 commits into
mainfrom
chore/remove-legacy-references

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Pin TF-Minecraft/TLibs/.github/actions/setup-plugins to 8ef41de on TLibs main. The previous pin, 4f7a354, is the head of TLibs PR Unify plugin artifact naming, validation, and ignore rules #19 and is not on any branch (Unify plugin artifact naming, validation, and ignore rules #19 was squash-merged as 8f48e6f). The action itself is unchanged; since then the installer has only dropped its unused --assets option and added GemInfusion to its catalogue.
  • Remove -P'!deploy-live' from the Maven commands. No POM defines a deploy-live profile, so the flag does nothing.
  • PR template: drop the plugin.yml/pom.xml version drift note. plugin.yml is filtered from the POM and release versions come from tags.

Verification

  • The build workflow runs on this PR. The release workflow gets the same edits but only runs on tags.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated automated build and release workflows to use refreshed dependency setup and apply the configured deployment profile during Maven tasks.
    • Updated pull request guidance about version changes.
    • No changes to end-user features or application behavior.

ryanbarlow97 and others added 2 commits September 24, 2026 20:42
The setup-plugins action was pinned to 4f7a354, the head of TLibs PR #19,
which is not on any TLibs branch. Pin it to 8ef41de on TLibs main. The
action is unchanged; its installer catalogue now also lists GemInfusion.

Drop -P'!deploy-live'. No POM defines a deploy-live profile, so the flag
does nothing.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
plugin.yml takes its version from the POM through resource filtering,
and release versions come from tags, so the two no longer drift.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 86ca7ad8-a66d-42e3-bd8f-ac0c3f88b275

📥 Commits

Reviewing files that changed from the base of the PR and between 280b8ef and 8b1da6e.

📒 Files selected for processing (3)
  • .github/pull_request_template.md
  • .github/workflows/build.yml
  • .github/workflows/maven-release.yml
💤 Files with no reviewable changes (1)
  • .github/pull_request_template.md

Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The Maven build and release workflows now use a different plugin-dependencies action pin. Their Maven commands no longer explicitly disable the deploy-live profile. The pull request template no longer includes a note about version drift.

Changes

Maven workflow updates

Layer / File(s) Summary
Update Maven workflow commands
.github/workflows/build.yml, .github/workflows/maven-release.yml
Both workflows use the updated plugin-dependencies action pin. Their version-setting, final-name evaluation, and verification commands no longer disable the deploy-live profile.

Pull request template

Layer / File(s) Summary
Remove version-drift note
.github/pull_request_template.md
The template no longer includes the note about version drift between plugin.yml and pom.xml or avoiding unrelated version bumps.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 8b1da

The workflow changes have no identified build regression, and the template edit removes advisory guidance without establishing a concrete failure. The PR appears ready subject to normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description clearly explains the changes and verification, but it omits the required Documentation impact, Contract, and Notes sections from the repository template. Add the required Documentation impact, Contract, and Notes sections. Include affected behavior, tests run or why tests were not run, player wiki impact, and the applicable configuration notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the two main changes: updating the CI action pin and removing the stale PR template note.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the build tonight
The profile stays within its call
A pinned step takes a newer turn
The template sheds one note
Then carrots wait beside the logs

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit 30f8ea7 into main Sep 24, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the chore/remove-legacy-references branch September 24, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant