Skip to content

ci: drop the no-op deploy-live profile flag - #5

Merged
ryanbarlow97 merged 1 commit into
mainfrom
chore/remove-legacy-references
Sep 24, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
chore/remove-legacy-references

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove -P'!deploy-live' from the Maven commands. No POM defines a deploy-live profile, so the flag does nothing.

Verification

  • The build workflow runs on this PR. The release workflow gets the same edits but only runs on tags.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Build and release checks now use Maven’s default profile selection when setting the project version, determining the artifact name, and running verification. This updates the profile selection used across both workflows; no changes to application features or user-facing behavior are included.

No POM defines a deploy-live profile, so -P'!deploy-live' does nothing.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 1d8a0e29-f244-46c2-b691-18264a7c60d1

📥 Commits

Reviewing files that changed from the base of the PR and between 9d8649c and 1d5e25f.

📒 Files selected for processing (2)
  • .github/workflows/build.yml
  • .github/workflows/maven-release.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

Both GitHub Actions workflows no longer pass -P'!deploy-live' to Maven when setting the project version, evaluating the artifact name, or running clean verify. These commands now use Maven’s default profile selection.

Changes

CI Maven profile selection

Layer / File(s) Summary
Use default Maven profile selection
.github/workflows/build.yml, .github/workflows/maven-release.yml
Version-setting, artifact-name evaluation, and verification commands no longer exclude the deploy-live profile.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 1d5e2

The supported CI workflows do not configure a deploy-live profile, and the repository defines none. Removing its exclusion does not present an actionable merge risk based on the available evidence.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the no-op deploy-live Maven profile flag from CI workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the build at night
Maven profiles now take flight
The version and name are set
Verify runs without the old flag yet
Hop, green checks greet the dawn!

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit a22c9ac into main Sep 24, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the chore/remove-legacy-references branch September 24, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant