Skip to content

ci: pin shared plugin setup to TLibs main - #25

Merged
ryanbarlow97 merged 1 commit into
mainfrom
chore/remove-legacy-references
Sep 24, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
chore/remove-legacy-references

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Pin TF-Minecraft/TLibs/.github/actions/setup-plugins to 8ef41de on TLibs main. The previous pin, 4f7a354, is the head of TLibs PR build: compile against Paper API 1.21.10 #19 and is not on any branch (build: compile against Paper API 1.21.10 #19 was squash-merged as 8f48e6f). The action itself is unchanged; since then the installer has only dropped its unused --assets option and added GemInfusion to its catalogue.
  • Remove -P'!deploy-live' from the Maven commands. No POM defines a deploy-live profile, so the flag does nothing.

Verification

  • The build workflow runs on this PR. The release workflow gets the same edits but only runs on tags.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Build and release workflows now follow Maven’s standard profile-selection rules when setting versions, evaluating project details, and running verification. As a result, the live-deployment profile may be active for these steps when its usual activation conditions are met. This aligns workflow behavior with Maven’s default profile selection.

The setup-plugins action was pinned to 4f7a354, the head of TLibs PR #19,
which is not on any TLibs branch. Pin it to 8ef41de on TLibs main. The
action is unchanged; its installer catalogue now also lists GemInfusion.

Drop -P'!deploy-live'. No POM defines a deploy-live profile, so the flag
does nothing.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3922e1fc-2994-45b3-8b5d-af4a888f1ee4

📥 Commits

Reviewing files that changed from the base of the PR and between 10e5405 and 70eb710.

📒 Files selected for processing (2)
  • .github/workflows/build.yml
  • .github/workflows/maven-release.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The build and Maven release workflows use a new pinned shared plugin setup action. Their Maven version-setting, name-evaluation, and clean verify commands no longer explicitly disable the deploy-live profile.

Changes

Maven Workflows

Layer / File(s) Summary
Update shared plugin setup pin
.github/workflows/build.yml, .github/workflows/maven-release.yml
Both workflows now reference commit 8ef41de589f121c98ff892b10696e7c1feb4ca74 for the shared plugin setup action.
Use normal Maven profile selection
.github/workflows/build.yml, .github/workflows/maven-release.yml
The version-setting, name-evaluation, and clean verify commands no longer explicitly disable deploy-live.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 70eb7

The workflow changes do not alter repository-defined Maven profiles and are ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: pinning the shared plugin setup action to a revision on TLibs main. It is concise and relevant, although it does not mention the secondary Maven profil…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the workflow pin,
Then watches Maven begin.
No profile is forced away,
The commands run their normal way.
I twitch my nose and hop along.

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit cdf9935 into main Sep 24, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the chore/remove-legacy-references branch September 24, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant