Skip to content

fix: reword player messages in character - #32

Merged
ryanbarlow97 merged 1 commit into
mainfrom
copy/rp-wording
Oct 1, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
copy/rp-wording

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

Summary

Rewords player-facing gameplay messages that broke immersion with server terms (permissions, access, containers, entities, chunks, plugin names) so they read in character. Staff and admin commands, usage help and setup errors keep their plain wording. Wording only: no permission checks or message routing change.

Before and after

Colour codes are omitted; the code keeps them.

Before After
Lacking Scroll You need the right scroll for this.
No item to apply skin on in your inventory You carry nothing this design can be applied to.

Testing

mvn -o verify passes: 24 tests, 0 failures.

🤖 Generated with Claude Code

Replace out-of-character wording in gameplay messages (permissions,
containers, entities, chunks, plugin tags) with in-world phrasing.
Staff commands, usage help and setup errors keep their plain wording.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 464e69cd-83da-4671-99ae-49e4c2e06596

📥 Commits

Reviewing files that changed from the base of the PR and between 391ffa7 and 71857ff.

📒 Files selected for processing (1)
  • src/main/java/net/tfminecraft/armourshop/managers/SkinManager.java

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Style
    • Updated messages shown when the required scroll is missing or no applicable item is found.

Walkthrough

SkinManager.applySkin now uses updated messages when the required scroll is missing or no applicable item is available. The checks, returns, sounds, and skin-application flow are unchanged.

Changes

Skin application messages

Layer / File(s) Summary
Failure message text
src/main/java/net/tfminecraft/armourshop/managers/SkinManager.java
The missing-scroll message changes to “You need the right scroll for this.” The no-applicable-item message changes to “You carry nothing this design can be applied to.”

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 71857

The change updates two skin-application failure messages without a supported behavior regression; no merge-blocking risk is identified.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit 0a4c957 into main Oct 1, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the copy/rp-wording branch October 1, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant